Skip to content

Commit

Permalink
CLOUD-3175: avoid using rdctl for switching to virtiofs (#92)
Browse files Browse the repository at this point in the history
Turns out rancher needs to actually be running to use `rdctl` to modify
settings:
```
$ $HOME/.rd/bin/rdctl set --experimental.virtual-machine.mount.type virtiofs
Error: connection refused
```

This PR changes to updating the plist file instead to use virtiofs.
  • Loading branch information
pb-dod authored Apr 12, 2024
1 parent 588335d commit fc83ddb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.52
0.1.53
2 changes: 1 addition & 1 deletion formula/ih-core.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class IhCore < Formula
VERSION="0.1.52"
VERSION="0.1.53"
desc "Brew formula for installing core tools used at Included Health engineering."
homepage "https://github.com/ConsultingMD/homebrew-ih-public"
license "CC BY-NC-ND 4.0"
Expand Down
6 changes: 4 additions & 2 deletions lib/core/rancher/step.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ function ih::setup::core.rancher::test() {
elif ! grep -q "<string>vz</string>" "$PLIST_DST"; then
ih::log::debug "The PLIST file needs to be updated to use 'vz' for M3 Macs."
return 1
# TODO: figure out how to check virtual-machine.mount.type (there's no rdctl get)
elif ! grep -q "<string>virtiofs</string>" "$PLIST_DST"; then
ih::log::debug "The PLIST file needs to be updated to use 'virtiofs' for M3 Macs."
return 1
fi
fi

Expand Down Expand Up @@ -167,7 +169,7 @@ function ih::setup::core.rancher::install() {
elif ! grep -q "<string>vz</string>" "$PLIST_DST"; then
ih::log::debug "Updating PLIST to use 'vz' for Virtualization for M3 Macs."
sudo sed -i '' 's/<string>qemu<\/string>/<string>vz<\/string>/g' "$PLIST_DST"
$HOME/.rd/bin/rdctl set --experimental.virtual-machine.mount.type virtiofs
sudo sed -i '' 's/<string>reverse-sshfs<\/string>/<string>virtiofs<\/string>/g' "$PLIST_DST"
fi
fi

Expand Down

0 comments on commit fc83ddb

Please sign in to comment.