Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Merge upstream master #1

Open
wants to merge 408 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
408 commits
Select commit Hold shift + click to select a range
2325381
app: skip failing TestAndroidApp test
Feb 14, 2018
4113bce
bind/java: remove android support library dependency in test
Feb 15, 2018
cdc0752
internal/binres: skip resources tests if android.jar of api 15 is mis…
Feb 14, 2018
8a8a989
cmd/gomobile: run go install in c-shared mode only if NDK is set
Feb 23, 2018
70bad68
cmd/gomobile: remove redundant build
Mar 6, 2018
eac3319
cmd/gomobile: don't dump certificate to test log
Mar 9, 2018
bcd28df
all: fix non-standard "DO NOT EDIT" comments for generated files
Mar 10, 2018
b7e3346
cmd/gomobile: update gomobile bind -help text
Mar 7, 2018
f9a2331
CONTRIBUTING.md: remove note about not accepting Pull Requests
andybons Mar 14, 2018
f161431
bind, cmd/gobind/test: remove GOOS build tags from test packages
Mar 7, 2018
4600df5
bind, cmd: generate complete standalone bindings from gobind
Mar 7, 2018
37c5126
misc/androidstudio/src/main/groovy/org/golang/mobile: update gobind path
Mar 9, 2018
2f2872e
example/reverse: delete
Mar 16, 2018
b392a2d
bind: handle import paths without trailing slashes correctly
Mar 9, 2018
c922c29
bind: add nil and bool to ObjC keyword list
Mar 14, 2018
70293e6
bind: skip incompatible constructors in ObjC bindings
Mar 16, 2018
671e1c1
bind: avoid header guard clashes for uppercase Go packages
Mar 16, 2018
8ee74ac
bind: support underscores in identifiers
Mar 16, 2018
57eb1e2
bind/benchmark: move package to testdata
Mar 21, 2018
598bfe4
cmd/gomobile: support vendored "golang.org/x/mobile/..." packages
pankona Mar 22, 2018
6b7c05d
cmd/gomobile: use standalone NDK toolchains
Mar 15, 2018
b07e525
cmd/gomobile: make sure gobind is installed and updated
Mar 16, 2018
5d85226
cmd/gobind,cmd/gomobile: support the default GOPATH
Mar 16, 2018
2a86fdc
cmd/gomobile: don't ignore -openal if no NDK was found
Mar 16, 2018
ae1772d
x/mobile/cmd/gomobile: allow digits-only basename for Android package…
hajimehoshi Mar 26, 2018
4e3d9b7
cmd/gomobile: add missing checks for the NDK and Xcode
Mar 28, 2018
54bca60
app,cmd/gomobile,exp/gl/glutil: support target architectures for iOS …
Mar 28, 2018
19987bc
cmd/gomobile: fix tests
Apr 3, 2018
3a7f113
app,exp/gl/glutil: add missing build directives
Apr 3, 2018
29776d8
app: support importing the package for bind programs
Apr 3, 2018
90139f6
cmd/gomobile: don't run gobind with the ios tag
Apr 3, 2018
1f177cb
bind: ignore unsupported basic types
Apr 8, 2018
5b452fe
bind: split out Seq.getRef calls with Go references
Apr 13, 2018
e7d878f
bind: replace Java finalizers with PhantomReferences
Apr 13, 2018
60d29bf
bind: pin Go objects while incrementing their reference count
Apr 14, 2018
5bfa0d1
cmd/gomobile,cmd/gobind: allow per-platform bindings again
Mar 9, 2018
7d79e14
cmd/gobind: make sure to set exit code on type checking errors
Apr 19, 2018
9422505
gl: remove duplicate build tag
Apr 19, 2018
5d5d88d
cmd/gomobile: add CGO_ENABLED=1 to gobind runs
Apr 19, 2018
ada9ee7
misc/androidstudio/src: drop the -i flag to avoid writing to a read-o…
i9 Apr 25, 2018
e6f3196
cmd/gomobile: use go list -f {{.Stale}} to determine staleness
Apr 19, 2018
60c2e06
misc/androidstudio: publish 0.2.12
hyangah Apr 25, 2018
bf2d30a
cmd/gomobile: disable DWARF in gomobile builds
Apr 28, 2018
721e994
internal/mobileinit,bind/java,app: don't treat jobject as a pointer
Apr 30, 2018
3fc6e85
bind/objc: fix benchmark test
Apr 28, 2018
58fd324
bind/objc: generate Xcode test files for iOS tests
Apr 28, 2018
c909788
cmd/gobind: fix build of ObjC bindings with a custom prefix
Apr 28, 2018
5a56f36
misc/androidstudio: drop the clean task to fix Android Studio gradle …
May 9, 2018
274da16
misc/androidstudio: release 0.2.13
hyangah May 10, 2018
9b0d538
bind: copy documentation for interface methods to ObjC
May 21, 2018
269a7ef
exp/audio/al: add windows support
kivutar May 22, 2018
002e3c5
cmd/gobind: copy documentation to generated source
May 21, 2018
5665cf3
bind/java: bump android plugin version to 3.0.1
May 21, 2018
c37eee0
bind/objc: fix comment
Jun 13, 2018
6621de0
cmd/gomobile: fix gomobile build of non-main packages for iOS
Jun 18, 2018
56e3592
internal/mobileinit,app: declare C symbols static
Jul 10, 2018
c7f1239
asset: hoist global variable to Go and make C function static
Jul 19, 2018
371a4e8
bind: use 0 instead of nil for the jclass zero value
Jul 19, 2018
5078169
app: add RunOnJVM to allow Cgo access to the Android JVM and context
Aug 5, 2018
bceb7ef
app: fix cgo exported function signature
Aug 7, 2018
fe88d27
app: fix hang when application is closed
veger Aug 28, 2018
0ff8172
gl: add internalFormat to TexImage2D
Sep 4, 2018
6c7f9ea
cmd/gomobile: specify clang++ compiler for C++ compilation, setup CGO…
tadovas Sep 13, 2018
6d4b718
app: make GoNativeActivity.getKey static
Sep 13, 2018
9bd09ef
cmd/gomobile: remove note about incomplete support on iOS
Sep 14, 2018
18ac050
cmd/gomobile: make the minimum iOS sdk version configurable
tadovas Sep 15, 2018
3409eff
bind: pass correct arguments to fromSlice and toSlice
tadovas Sep 17, 2018
756a47a
bind: fix generated JNI name for Go packages with underscores
Sep 17, 2018
f9c3329
bind: add support for Objective-C unsigned char to reverse bindings
tadovas Sep 18, 2018
920b52b
cmd/gomobile: bump minimum sdk version and update gradle for NDK 18
Sep 22, 2018
92f3b9c
misc,example/bind/hello: remove the Gradle plugin
Oct 10, 2018
a27dd33
cmd/gomobile: use the correct case for the generated Universe.objc.h …
tadovas Oct 26, 2018
ca3c581
all: use "reports whether" in godoc comments
tklauser Nov 30, 2018
9a2b479
cmd/gomobile: bump required Go version to 1.10
Jan 3, 2019
dc07713
cmd/gomobile: require -bundleid set for -target=ios
Jan 7, 2019
9f49127
bind: use property syntax for ObjC
champo Jan 25, 2019
58b5a00
bind: fix tests for the always enabled go cache
eliasnaur Jan 25, 2019
07b47c2
internal/importers/objc: fix parsing of newer clang output
eliasnaur Jan 25, 2019
feefccb
bind: ignore type aliases to basic types
federicobond Jan 25, 2019
a421117
bind: always include ref.h in generated ObjC headers
steeve Jan 26, 2019
8b05ea2
bind/testdata: support JDK 8 for the reverse binding golden tests
eliasnaur Feb 22, 2019
ca80213
cmd/gomobile: use the NDK r19b prebuilt toolchains
eliasnaur Feb 22, 2019
2c6ea15
cmd/gobind,cmd/gomobile: don't go install binaries
eliasnaur Mar 1, 2019
e6099be
cmd/gomobile: add generated package names to proguard.txt
eliasnaur Mar 1, 2019
246a998
cmd/gomobile: work around broken Windows NDK compiler scripts
eliasnaur Feb 27, 2019
3ac37b7
cmd/gomobile: bump default iOS minimum version to 7.0
eliasnaur Mar 1, 2019
b8c6dab
all: skip or fix tests for GOOS=android
eliasnaur Mar 1, 2019
b826ec1
bind: annotate ObjC types with nullability annotations
champo Mar 5, 2019
9ce7b04
cmd/gomobile: fix tests
eliasnaur Mar 6, 2019
56dec8b
cmd/gomobile: fix tests on builders
eliasnaur Mar 6, 2019
874a4fb
app,exp,gl: fix build
eliasnaur Mar 6, 2019
d2e1c1c
cmd/gomobile: improve NDK version detection
eliasnaur Mar 7, 2019
d3739f8
cmd/gobind: fix tests on the linux-amd64-longtest builder
eliasnaur Mar 12, 2019
f0d57f4
all: set GO111MODULE=off explicitly in bind tests
Mar 12, 2019
a4d62f3
all: add go.mod
Mar 12, 2019
f2ef6f4
bind/java: deflake testJavaRefKeep
eliasnaur Mar 14, 2019
cde3d95
cmd/gomobile: explicitly disable modules
eliasnaur Mar 16, 2019
6bd1229
bind,bind/testdata: skip conflicting Java constructors
eliasnaur Mar 16, 2019
9487ef5
cmd/gomobile: enable bitcode
eliasnaur Mar 19, 2019
167ebed
cmd/gomobile: require NDK r19c and delete workaround for NDK r19b
eliasnaur Mar 21, 2019
28c689b
bind: annotate all remaining ObjC types for nullability
champo Apr 12, 2019
3e0bab5
cmd/gomobile: fall back to $ANDROID_NDK_HOME for the NDK path
quite Apr 14, 2019
12c8d8c
cmd/gomobile: update doc
hyangah May 9, 2019
ab05907
cmd/gomobile: add arg to set android api level
AlexRouSg May 8, 2019
32b2708
cmd/bind: add remaining Objc nullability specifiers
MarkVillacampa May 9, 2019
6fa95d9
bind: keep package function comments in java file
i9 Jun 6, 2019
e47acb2
bind/java: Do not get ApplicationContext via reflection, ask for it w…
timcooijmans Jul 11, 2019
d2bd2a2
gl: provide dummy impl when cgo is disabled
nigeltao Jul 4, 2019
597adff
x/mobile: update dependencies
hajimehoshi Aug 3, 2019
e8b3e61
internal/importers: replace go/build usages with go/packages
hajimehoshi Aug 9, 2019
fe31116
all: use GOROOT/bin/go instead of go for tests
hajimehoshi Aug 23, 2019
30c70e3
all: use GOROOT/bin/go instead of go everywhere
hajimehoshi Aug 23, 2019
cafc553
cmd/gobind: fix build-tag, CGO and load trybot failures
hajimehoshi Aug 16, 2019
c6da959
bind/java, bind/objc: do not use module for reverse binding
hajimehoshi Aug 30, 2019
b558ed8
all: update go.mod
hajimehoshi Sep 10, 2019
d3ece3b
add -trimpath build flag.
fbzhong Sep 22, 2019
6d0d39b
bind: format generated go code before comparing with golden files
hyangah Oct 1, 2019
d309294
bind: update the golden data for Objective-C
hajimehoshi Oct 25, 2019
73ccc5b
cmd/gobind: replace go/build with go/packages in gen.go
hajimehoshi Oct 25, 2019
0945064
cmd/gobind: remove go/build and go/import usages from main.go
hajimehoshi Oct 25, 2019
c2e8f9e
cmd/gobind: add tests enabling Go modules
hajimehoshi Sep 17, 2019
6a1b097
cmd/gobind: enable TestDocs tested with Go modules
hajimehoshi Nov 12, 2019
f0c4003
cmd/gomobile: replace go/build with go/packages in bind
hajimehoshi Nov 12, 2019
26e634b
cmd/gomobile: remove a global variable
hajimehoshi Nov 20, 2019
8715129
cmd/gomobile: remove an unsed function
hajimehoshi Nov 20, 2019
08e574b
cmd/gomobile: replace go/build with go/packages in gomobile-build
hajimehoshi Nov 20, 2019
d9e324c
cmd/gomobile: remove go/build usages from build.go
hajimehoshi Nov 20, 2019
5c0e7e4
cmd/gomobile: change the working directory to $WORK/src/gobind when g…
hajimehoshi Nov 27, 2019
1a1fef8
cmd/gomobile: make gomobile-init support Go modules
hajimehoshi Dec 9, 2019
1d13e32
cmd/gomobile: enable Go modules in gomobile-bind
hajimehoshi Dec 9, 2019
b9f03b3
cmd/gomobile: remove the logic to clean the given path
hajimehoshi Jan 13, 2020
56347cc
cmd: replace goBin() with a plain string "go"
hajimehoshi Jan 15, 2020
af4a929
cmd/gomobile: enable Go modules at gomobile-build
hajimehoshi Jan 15, 2020
875e90d
cmd/gomobile: disable bitcode on Go 1.13 or older
hajimehoshi Jan 15, 2020
d70acc1
internal/binres: update wrong URL in comment
lusingander Jan 18, 2020
0c13fd3
gl: enable use of buffer objects for TexSubImage2D by nil
hajimehoshi Jan 2, 2020
1d4ecbb
cmd/gomobile: output an error message at gomobile-init
hajimehoshi Jan 21, 2020
23a0503
cmd/gomobile: enable Cgo
hajimehoshi Jan 14, 2020
82c397c
cmd/gomobile: always use abolute paths to replace in go.mod
hajimehoshi Jan 21, 2020
0df4eb2
cmd/mobile: add an arbitrary package to go-list at gomobile-init
hajimehoshi Feb 5, 2020
2b26a47
cmd/gomobile: handle modules replaced by other versioned modules
hyangah Feb 5, 2020
3c8601c
app: fix comparison of keys' direction
hajimehoshi Feb 22, 2020
4c31acb
cmd/gomobile: keep the module version information as much as possible
hajimehoshi Mar 29, 2020
33b8054
cmd/gomobile: use the specified output name for the module name on iOS
hajimehoshi Jun 22, 2020
588b2b2
cmd/gomobile: fix the error when specifying -target=ios with Go 1.15
hajimehoshi Jul 19, 2020
1a48f80
cmd/gomobile: use arm64 at packagesConfig
hajimehoshi Jul 9, 2020
68de546
cmd/gomobile: fix the test for Go 1.15
hajimehoshi Jul 21, 2020
bcce011
cmd/gomobile: remove darwin/386 support
hajimehoshi Jul 21, 2020
973feb4
cmd/gomobile: skip TestWriter
hajimehoshi Jul 21, 2020
da85bec
README.md: add badge to pkg.go.dev
julieqiu Dec 7, 2020
e6ae53a
gl: add darwin/arm64 (macOS) support
dmitshur Dec 17, 2020
e4a08af
cmd/gomobile: create go.sum at the temporary directory
hajimehoshi Feb 8, 2021
f462b39
app: support C compiler that defaults to -fno-common
thanm Feb 5, 2021
bdb1ca9
all: go fmt ./...
rsc Feb 19, 2021
7e97214
all: update golang.org/x/tools to v0.1.2
May 27, 2021
7c8f154
cmd/gomobile: remove unnecessary IsDir check
jmorag Jun 14, 2021
9361995
cmd/gomobile: enable the test for gomobile-build on iOS
hajimehoshi Jan 15, 2020
76c259c
cmd/gomobile: support macOS and Catalyst
ydnar Jul 9, 2021
34ab130
Revert "cmd/gomobile: support macOS and Catalyst"
hajimehoshi Jul 15, 2021
18b1a0c
cmd/gomobile: use Apple Development over iPhone Developer
changkun Aug 31, 2021
d82874c
cmd/gomobile: fix flaky TestNdkRoot test
changkun Aug 31, 2021
9cba7bc
cmd/gomobile: handle NDK path for darwin/arm64
changkun Aug 31, 2021
f7a6293
cmd/gomobile: extract import packages more robust
changkun Aug 31, 2021
1fde1d6
cmd/gomobile: remove unused binary xml
changkun Aug 31, 2021
a0f9ae5
cmd/gomobile: allow tests to pass on ios builder
changkun Sep 1, 2021
80cb72e
cmd/gomobile: use GOOS=ios for iOS builds
changkun Aug 30, 2021
ddd6497
cmd/gomobile: enable bitcode unconditionally
changkun Sep 1, 2021
5d9a332
example/ivy: make ivy work again
changkun Sep 1, 2021
6d8ad35
cmd/gomobile: improve support for macOS and Catalyst
ydnar Sep 16, 2021
b17b856
cmd/gomobile: embed teamID into Xcode project settings
changkun Sep 22, 2021
b5eb1ab
example: updates for XCFramework and Mac Catalyst
ydnar Sep 17, 2021
1c027f3
cmd/gomobile: fix header padding computation in apk generation
wmdngngng Sep 23, 2021
122ae57
go.mod: update golang.org/x/tools@316ba0b
hyangah Oct 22, 2021
eb3c0ab
example/ivy: make ivy as a separate module, and update to use AndroidX
hyangah Oct 16, 2021
3e409ee
example/ivy/android: use monospace & pre-wrap for WebView text format…
hyangah Oct 18, 2021
d263bad
example/ivy/android: use escapeHtmlTags in ivy output processing
hyangah Oct 19, 2021
93c5f8a
example/ivy/android: fix demo to handle comments & 'quit' correctly
hyangah Oct 19, 2021
7b8bfe0
example/ivy/android: remove prompt symbol
hyangah Oct 19, 2021
170e11b
example/ivy/ios: enable demo functionality
robaho Oct 22, 2021
2ab7fee
example/ivy/ios: enable return to continue demo
robaho Nov 1, 2021
e68c988
example/ivy/ios: format code according to Google style guide
robaho Nov 2, 2021
198acf5
app: add missing header for XVisualInfo and other X11 declarations
Nov 9, 2021
d61a72f
example/ivy: add a "// +build" comment in tools.go
Nov 9, 2021
fea317f
cmd/gomobile: use LLVM binutils if GNU binutils are missing
changkun Dec 3, 2021
1ab9019
example/ivy/ios: turn off quoted include warning from clang
changkun Dec 5, 2021
29d5ad4
cmd/gomobile: remove outdated TODO of bundle ID
changkun Dec 5, 2021
3d43a27
app: remove outdated TODO of app termination
changkun Dec 5, 2021
4e6c292
cmd/gomobile: remove binary XML
changkun Dec 5, 2021
cde37c6
all: add GLES_SILENCE_DEPRECATION to suppress warnings
hajimehoshi Jan 4, 2022
5579029
all: add -DGLES_SILENCE_DEPRECATION instead of #define
hajimehoshi Jan 4, 2022
4a8be17
all: add go:build comments for .m and .c files
hajimehoshi Jan 4, 2022
858099f
cmd,bind: add implicit dependencies
hyangah Jan 11, 2022
4f294b3
app: resolve build warnings
changkun Feb 21, 2022
032b214
cmd/gomobile: add missing latest tag to gobind
morningsend Feb 10, 2022
8a0a1e5
example/ivy/android: update app version (1.4.0)
hyangah Nov 2, 2021
55113b9
mobile: fix some typos
cuishuang Mar 4, 2022
447654d
example/ivy: update robpike.io/ivy/mobile to 0.2.7
hyangah Feb 28, 2022
e579adb
app: allow app.Main to return on Windows
changkun Dec 4, 2021
ce6a79c
all: gofmt
rsc Apr 11, 2022
50dca8f
cmd/gomobile: tidy a few unused code and variables
changkun Dec 5, 2021
eae5320
bind: added protocol documentation to Objective-C generated file
hilariocoelho May 17, 2022
8578da9
all: modernize handling of Android SDK and NDK paths
Apr 21, 2022
aaac322
A+C: delete AUTHORS and CONTRIBUTORS
rsc Jul 22, 2022
fa6bcb0
cmd/gomobile: concurrent gomobile-bind building for Android
hajimehoshi Aug 28, 2022
58284a7
cmd/gomobile: clean-up the code using gobind for iOS
hajimehoshi Sep 30, 2022
c746ac2
all: fix a few function names on comments
cuishuang Oct 11, 2022
3eb8272
cmd/gobind: exec the test binary as gobind and log only stderr by def…
Oct 18, 2022
51f526d
go.mod: update dependency on x/tools/go/packages
Oct 18, 2022
406ed3a
cmd/gobind: do not compile package just to find package dir
hyangah Oct 19, 2022
b36e624
cmd/gomobile: concurrent build for iOS archive files
hajimehoshi Oct 11, 2022
43a0384
all: remove redundant type conversion
cuishuang Sep 7, 2022
e0f5769
cmd/gomobile: update the doc about the minimum Android SDK version
hajimehoshi Mar 1, 2023
e8d11dd
cmd/gobind: remove repeated definite articles
cuishuang Apr 27, 2023
3c911d8
cmd/gomobile: upgrade minimal javac version to 1.8
SuzukiHonoka May 31, 2023
7088062
all: upgrade x/tools and its dependencies
Aug 18, 2023
52620a4
all: upgrade dependencies
hajimehoshi Sep 1, 2023
fbe1c05
all: update Go version to 1.18
hajimehoshi Sep 1, 2023
dc64209
cmd/gomobile: add go statements to autogenerated go.mod files
hajimehoshi Sep 5, 2023
2077a32
go.mod: update golang.org/x dependencies
gopherbot Sep 6, 2023
e2f4524
cmd/gomobile: resolve symbolic links as a workaround for an Xcode bug
hajimehoshi Sep 21, 2023
2b44d11
go.mod: update golang.org/x dependencies
gopherbot Oct 6, 2023
35478a0
go.mod: update golang.org/x dependencies
gopherbot Nov 8, 2023
76ac687
go.mod: update golang.org/x dependencies
gopherbot Nov 27, 2023
c713f31
go.mod: update golang.org/x dependencies
gopherbot Jan 11, 2024
d1f7d34
go.mod: update golang.org/x dependencies
gopherbot Feb 12, 2024
19e4cdf
cmd/gomobile: fix a compatibility issue with Xcode 15.3
scosman Mar 17, 2024
c58ccf4
go.mod: update golang.org/x dependencies
gopherbot Mar 5, 2024
c76e57e
all: remove the repetitive words
vitalmotif Mar 20, 2024
268e6c3
cmd/gomobile: produce frameworks which follow Apple's specs per platf…
scosman Mar 25, 2024
365c353
cmd/gomobile: add CFBundleShortVersionString and CFBundleVersion, fix…
scosman Mar 29, 2024
755f4ef
cmd/gomobile: fix error message to reflect current build target
sbruens Feb 16, 2024
09dbf07
go.mod: update golang.org/x dependencies
gopherbot Apr 4, 2024
a1a533f
go.mod: update golang.org/x dependencies
gopherbot May 6, 2024
fa72add
all: replace ALooper_pollAll with ALooper_pollOnce
hajimehoshi May 18, 2024
2782386
go.mod: update golang.org/x dependencies
gopherbot Jun 4, 2024
b765e5d
go.mod: update golang.org/x dependencies
gopherbot Jul 7, 2024
1ad2df2
LICENSE: update per Google Legal
rsc Jul 16, 2024
81131f6
go.mod: update golang.org/x dependencies
gopherbot Aug 6, 2024
7c49166
all: fix printf(var) mistakes detected by latest printf checker
dmitshur Sep 4, 2024
6429502
go.mod: update golang.org/x dependencies
gopherbot Sep 9, 2024
c6794c9
asset: do not use 'assets' directory for iOS
hajimehoshi Sep 30, 2024
08a83c5
go.mod: update golang.org/x dependencies
gopherbot Oct 4, 2024
7ff8300
cmd/gomobile: use Output instead of CombinedOutput at envClang
hajimehoshi Oct 15, 2024
2b9d635
README: mention the git repo
ianlancetaylor Nov 5, 2024
cee99c0
example/ivy: use tools build constraint in tools.go
dmitshur Nov 8, 2024
fa514ef
go.mod: update golang.org/x dependencies
gopherbot Nov 8, 2024
ce44b27
go.mod: update golang.org/x dependencies
gopherbot Dec 4, 2024
a87c1cf
cmd/gomobile: work around for corrupted build on Mac Catalyst
hyangah Dec 11, 2024
5e5de4c
all: make function and struct comments match the names
cuishuang Jan 1, 2025
c31d5b9
go.mod: update golang.org/x dependencies
gopherbot Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cmd/gomobile: resolve symbolic links as a workaround for an Xcode bug
On macOS, a temporary directory starts with /var, which is a symbolic
link to /private/var. And in gomobile, a temporary directory is usually
used as a working directly. Unfortunately, xcodebuild in Xcode 15 seems
to have a bug and might not be able to understand fullpaths with
symbolic links. As a workaround, resolve the path with symbolic links by
filepath.EvalSymlinks.

Fixes golang/go#63141

Change-Id: Ieb684223192fc3e354b79dededaecdb0b25937e6
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/530135
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Hajime Hoshi <hajimehoshi@gmail.com>
  • Loading branch information
hajimehoshi authored and gopherbot committed Sep 22, 2023
commit e2f452493d570cfe278e63eccec99e62d4c775e5
8 changes: 8 additions & 0 deletions cmd/gomobile/bind_iosapp.go
Original file line number Diff line number Diff line change
@@ -269,6 +269,14 @@ func goAppleBind(gobind string, pkgs []*packages.Package, targets []targetInfo)
xcframeworkArgs := []string{"-create-xcframework"}

for _, dir := range frameworkDirs {
// On macOS, a temporary directory starts with /var, which is a symbolic link to /private/var.
// And in gomobile, a temporary directory is usually used as a working directly.
// Unfortunately, xcodebuild in Xcode 15 seems to have a bug and might not be able to understand fullpaths with symbolic links.
// As a workaround, resolve the path with symbolic links by filepath.EvalSymlinks.
dir, err := filepath.EvalSymlinks(dir)
if err != nil {
return err
}
xcframeworkArgs = append(xcframeworkArgs, "-framework", dir)
}