Hardcode Bellatrix Terminal Blocks for all known networks #8943
+83
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix the tests, of course |
|
Ready for review |
tbenr
reviewed
Jan 7, 2025
There was a problem hiding this comment.
The annoying effect with this is that we are going to print the warning at startup
2025-01-07 15:19:26.425 WARN - Bellatrix parameter TERMINAL_BLOCK_HASH has been overridden to 0x55b11b918355b1ef9c5db810302ebad0bf2544255b530cdce90674d5887bb286
2025-01-07 15:19:26.425 WARN - Bellatrix parameter TERMINAL_BLOCK_HASH_ACTIVATION_EPOCH has been overridden to 146875
we could demote the log to INFO .. or print those only of they have been changed from the default but don't know if this approach become too complex
|
@tbenr nice catch, I will think how to make it less noisy |
2 tasks
tbenr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Links for verification:
Mainnet:
https://beaconcha.in/block/15537394
Sepolia:
https://sepolia.etherscan.io/block/1450409
Gnosis:
https://gnosisscan.io/block/25349537
Chiado
https://beacon.chiadochain.net/slot/436224
May worth updating docs and changelog
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog