Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test case for comparing mainnet config output #8917

Merged
merged 7 commits into from
Dec 16, 2024
Merged

added test case for comparing mainnet config output #8917

merged 7 commits into from
Dec 16, 2024

Conversation

rolfyone
Copy link
Contributor

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr mentioned this pull request Dec 13, 2024
Merged
2 tasks
@rolfyone rolfyone marked this pull request as ready for review December 14, 2024 22:59
tbenr
tbenr approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I proposed a version that works with maps and leverage the assertion comparison to give diff entries

...structure/json/src/testFixtures/java/tech/pegasys/teku/infrastructure/json/JsonTestUtil.java Show resolved Hide resolved
@tbenr tbenr enabled auto-merge (squash) December 16, 2024 09:23
@tbenr tbenr merged commit b5dd2ae into Consensys:master Dec 16, 2024
17 checks passed
@rolfyone rolfyone deleted the config-spec-output-test branch December 16, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfyone @tbenr