Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SingleAttestation in PerformanceTracker bug #8902

Merged

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 9, 2024

When we produce an attestation we save it in saveProducedAttestation.
If it is a singleAttestation it will break the PerformanceTracker because it is designed to work for non-single attestations.

This pr makes sure we save converted attestations

@tbenr tbenr changed the title Fix SingleAttestation and PerformanceTracker bug Fix SingleAttestation in PerformanceTracker bug Dec 9, 2024
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit d10a47d into Consensys:master Dec 9, 2024
17 checks passed
@tbenr tbenr deleted the fix-performance-tracker-single-attestation branch December 9, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants