Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are incorrectly calculating relevant blobs topics for upcoming forks.
When new specConfig has been introduced, an assumption has been broken in
Eth2GossipTopicFilter
, which was passing the current milestone togetAllTopics
even when calculating topics for the future forks.It was fine because
getAllTopics
is only getting the config and from the spec, which in previous specConfig design was always the "latest defined milestone config".With recent changes, it is no more the case, so we need to pick config from the correct milestone.
Unit test was broken because it was passing the wrong milestone (the next fork milestone, instead of the current one)
I fixed the bug and the tests.
Moreover the Electra blobs bump would have break
getAllTopics
in blob topics calculation. Thanks to new dynamic spec config, that works transparently now.Documentation
doc-change-required
label to this PR if updates are required.Changelog