Logic to handle new validators during epoch processing #8874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Dec 3, 2024
| final BeaconState state, | ||
| final ValidatorStatuses validatorStatuses, | ||
| final UInt64 currentEpoch) { | ||
| final int preValidatorCount = validatorStatuses.getValidatorCount(); |
There was a problem hiding this comment.
i'd probably call this cachedValidatorCount
rolfyone
reviewed
Dec 3, 2024
| final ValidatorStatuses validatorStatuses, | ||
| final UInt64 currentEpoch) { | ||
| final int preValidatorCount = validatorStatuses.getValidatorCount(); | ||
| final int postValidatorCount = state.getValidators().size(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR updates epoch processing logic to consider that post-Electra, the validator set can be updated in the mid-epoch processing (this did not happen before). The gist of the change is that we might need to update our
ValidatorStatusesobject, which acts as a cache of the validators in the validator set. We don't ever want to run this logic before Electra, and even in Electra, we only want to do it if we detect the validator set has changed.Fixed Issue(s)
fixes #8849
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog