Track produced block when builder doesn't reveal the payload #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
reviewed
Nov 27, 2024
Comment on lines
82
to
89
| if (ex != null) { | ||
| // in case of relay API timeouts when unblinding, we still want to assume the block | ||
| // as produced, since the relay could have published it | ||
| if (ExceptionUtil.hasCause(ex, TimeoutException.class)) { | ||
| performanceTracker.saveProducedBlock(blockContainer.getSignedBlock()); | ||
| } | ||
| } else { | ||
| performanceTracker.saveProducedBlock(block); |
There was a problem hiding this comment.
do we really need to discriminate the exception here? wandering if we can save the block as produced
There was a problem hiding this comment.
It doesn't hurt since we filter in the tracker compared to the chain we have anyways and exceptions shouldn't really happen
There was a problem hiding this comment.
but you could have a bunch of errors on API side, not just a timeout, and you never know if on the other side it got the info to publish.
Moreover, I think that we know we attempted to publish a produced block, so it make sense to me to blindly track it at the very beginning of the flow...
There was a problem hiding this comment.
Committed a change to always save the block as produced
StefanBratanov
force-pushed
the
fix_8841
branch
from
2ea8fe9 to
7c892af
Compare
tbenr
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Move the tracking of the produced block to the ValidatorApiHandler where we produce the unsigned block. I find this approach easier and more consistent than passing the
PerformanceTrackerall the way down toExecutionBuilderModuleFixed Issue(s)
fixes #8841
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog