Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More schema registry migration #8832

Merged
merged 8 commits into from
Nov 15, 2024
Merged

More schema registry migration #8832

merged 8 commits into from
Nov 15, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 15, 2024 •
edited
Loading

This migrates:

  • BeaconBlockBody
  • BeaconBlock
  • SignedBeaconBlock
  • ExecutionPayload
  • ExecutionPayloadHeader
  • ExecutionRequest

And blinded counterparts when applicable

the blinded schemas has been renamed (BlindedBlock -> BlindedBeaconBlock) to be aligned with their non-blinded counterparts.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

zilm13
zilm13 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few nits

ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/SchemaDefinitionsCapella.java Outdated Show resolved Hide resolved
ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/SchemaDefinitionsDeneb.java Outdated Show resolved Hide resolved
ethereum/spec/src/main/java/tech/pegasys/teku/spec/schemas/SchemaDefinitionsDeneb.java Outdated Show resolved Hide resolved
@tbenr tbenr merged commit d5c332f into Consensys:master Nov 15, 2024
17 checks passed
@tbenr tbenr deleted the more-schemaRegistry-migration branch November 15, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @zilm13