Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate and proof in schema registry #8770

Merged

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Oct 22, 2024

AggregateAndProof and SignedAggregateAndProof migration to schema registry.

Fixed a bug in attestation provider that has not broken Deneb just because I missed using the registry in the schema definition class :)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha merged commit e2a9019 into Consensys:master Oct 22, 2024
17 checks passed
@lucassaldanha
Copy link
Member

Fixed a bug in attestation provider that has not broken Deneb just because I missed using the registry in the schema definition class :)

Epic!

Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr deleted the AggregateAndProof-in-schema-registry branch October 23, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants