Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded VC API tests #8757

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Expanded VC API tests #8757

merged 1 commit into from
Oct 20, 2024

Conversation

rolfyone
Copy link
Contributor

fixes #8756

Added test cases for VC block requests, and added a validation to the Attestation request test. These were the 2 VC cases where we now require that header to be specified or we will fail.

There was another case in DSL for AT, but we'll see those quickly if we use it.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

fixes Consensys#8756

Added test cases for VC block requests, and added a validation to the Attestation request test. These were the 2 VC cases where we now require that header to be specified or we will fail.

There was another case in DSL for AT, but we'll see those quickly if we use it.

Signed-off-by: Paul Harris <[email protected]>
@rolfyone rolfyone merged commit 9f28a87 into Consensys:master Oct 20, 2024
17 checks passed
@rolfyone rolfyone deleted the 8756 branch October 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify headers on all json payloads from VC
2 participants