refactored logging for inclusion on gossip channels. #8733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/GossipFailureLogger.java
Fixed
Show fixed
Hide fixed
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/GossipFailureLogger.java
Fixed
Show fixed
Hide fixed
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/GossipFailureLogger.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
rolfyone
commented
Oct 23, 2024
| @@ -87,6 +88,10 @@ public void gossip(final Bytes bytes) { | |||
| SafeFuture.of(publisher.publish(Unpooled.wrappedBuffer(bytes.toArrayUnsafe()), topic)) | |||
| .finish( | |||
| () -> LOG.trace("Successfully gossiped message on {}", topic), | |||
| err -> LOG.debug("Failed to gossip message on " + topic, err)); | |||
There was a problem hiding this comment.
the full stack here got pretty unusable pretty quickly.
rolfyone
commented
Oct 23, 2024
| @@ -43,7 +43,7 @@ void shouldLogAlreadySeenErrorsAtDebugLevel() { | |||
| void shouldLogFirstNoPeersErrorsAtWarningLevel() { | |||
| try (final LogCaptor logCaptor = LogCaptor.forClass(GossipFailureLogger.class)) { | |||
| logger.logWithSuppression( | |||
| new RuntimeException("Foo", new NoPeersForOutboundMessageException("So Lonely")), SLOT); | |||
| new RuntimeException("Foo", new SemiDuplexNoOutboundStreamException("So Lonely")), SLOT); | |||
There was a problem hiding this comment.
this SemiDuplex exception used to share implementation with NoPeers error handling so this still tests the same thing and all the logic continues to work.
tbenr
reviewed
Oct 23, 2024
Comment on lines
57
to
60
| } else if (lastRootCause instanceof SemiDuplexNoOutboundStreamException) { | ||
| LOG.log( | ||
| suppress ? Level.DEBUG : Level.WARN, | ||
| "Failed to publish {}(s) for slot {} because no peers were available on the required gossip topic", |
There was a problem hiding this comment.
this seems to me the message for NoPeersForOutboundMessageException. And the above seems a more generic one so matching SemiDuplexNoOutboundStreamException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
investigating #8716
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog