Decouple block and blobs publishing\import #8728
Conversation
| } | ||
|
|
||
| // when broadcast validation is enabled, we need to wait for the validation to complete before | ||
| // publishing the block (and blob sidecars) | ||
|
|
||
| final SafeFuture<BlockImportAndBroadcastValidationResults> | ||
| blockImportAndBroadcastValidationResults = | ||
| importBlockAndBlobSidecars( | ||
| block, blobSidecars, broadcastValidationLevel, blockPublishingPerformance); | ||
| importBlock(block, broadcastValidationLevel, blockPublishingPerformance); |
There was a problem hiding this comment.
I feel it requires more refactoring. Isn't block import always going to fail, because blob sidecars are not imported.
There was a problem hiding this comment.
I changed the way I push data in the tracker. Now i put them separated and the import should wait until the tracker completes.
This is what I have in mind, need to test if it actually behaves this way:)
There was a problem hiding this comment.
this is actually working.
tbenr
changed the title
|
|
||
| blockImportAndBroadcastValidationResults | ||
| .thenCompose(BlockImportAndBroadcastValidationResults::broadcastValidationResult) | ||
| .thenAccept( | ||
| broadcastValidationResult -> { | ||
| if (broadcastValidationResult == BroadcastValidationResult.SUCCESS) { | ||
| publishBlockAndBlobSidecars(block, blobSidecars, blockPublishingPerformance); | ||
| publishBlock(block, blockPublishingPerformance) | ||
| .always( |
There was a problem hiding this comment.
Actually, why do we wait for block to finish publishing again and not just send both across async?
There was a problem hiding this comment.
that's a strategy that has been discussed in several places. The reason are essentially help solo stakers with low up bandwidth to reduce latency in block propagation. With the adoption of engine_getBlobs blobs can be retrieved once the block is known, thus it is good to give priority to the block over the blobs.
I'll put this under a feature flag.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../src/main/java/tech/pegasys/teku/validator/coordinator/publisher/AbstractBlockPublisher.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/validator/coordinator/publisher/AbstractBlockPublisher.java
Fixed
Show fixed
Hide fixed
tbenr
added
blocked by another PR/issue 💔
tbenr
force-pushed
the
detach-block-and-blobs-publishing
branch
from
6a1c0a6 to
d5218e6
Compare
add feature flag add a test
refactor tests
bug fix
tbenr
force-pushed
the
detach-block-and-blobs-publishing
branch
from
ad0ff80 to
5e2d991
Compare
* Decouple block and blobs publishing\import (#8728) * use correct schema definitions when creation full beacon block (#8806) * use correct schema definitions when creation full beacon block * use forkChoiceUpdatedV4 with PayloadAttributesV4 (#8752) (#8799) --------- Co-authored-by: Enrico Del Fante <[email protected]>
fixes #8682
PR Description
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog