Save earliest slot block in a DB variable #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
…or call Signed-off-by: Gabriel Fukushima <[email protected]>
…option Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
rolfyone
reviewed
Oct 15, 2024
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/KvStoreDatabase.java
Outdated
Show resolved
Hide resolved
…xt block after prune runs Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…le even when the slot after the last pruned is empty Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
rolfyone
reviewed
Oct 16, 2024
storage/src/main/java/tech/pegasys/teku/storage/server/kvstore/KvStoreDatabase.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Fukushima <[email protected]>
…or call Signed-off-by: Gabriel Fukushima <[email protected]>
…option Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…xt block after prune runs Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…le even when the slot after the last pruned is empty Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…t slot after prune runs Signed-off-by: Gabriel Fukushima <[email protected]>
…riable' into save-earliest-slot-block-in-dbvariable # Conflicts: # storage/src/integration-test/java/tech/pegasys/teku/storage/server/kvstore/DatabaseTest.java
…ble which should trigger fallback to iterator Signed-off-by: Gabriel Fukushima <[email protected]>
…riable' into save-earliest-slot-block-in-dbvariable
Signed-off-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
During the investigation on the mainnet sync issue it was found that this query can take a descent amount of time (it can vary from a few ms to 2 digits seconds). This information is used when a peer send a BeaconBlocksByRangeRequestMessage ultimately causing a disconnection from the peer's side if this query times out.
This data fetch could be optimised by storing the earliest block slot in a variable in the database.
Fixed Issue(s)
Fixes #8658
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog