Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused methods on ExecutionPayloadBuilder #8718

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Remove unused methods on ExecutionPayloadBuilder #8718

merged 3 commits into from
Oct 14, 2024

Conversation

lucassaldanha
Copy link
Member

PR Description

  • Remove old methods in ExecutionPayloadBuilder that are not being used anymore.

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone
rolfyone approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gfukushima
gfukushima approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we need to include executionRequests on the builder later on?

@gfukushima
Copy link
Contributor

missed removing some references in the EL Stub

@lucassaldanha
Copy link
Member Author

lucassaldanha commented Oct 14, 2024 •
edited
Loading

missed removing some references in the EL Stub

Remaining EL stub references are removed in this other PR: #8717

@lucassaldanha
Copy link
Member Author

lgtm, do we need to include executionRequests on the builder later on?

They are in another PR: #8717

@lucassaldanha lucassaldanha force-pushed the remove-builder-unused-methods branch from 46ee890 to fe80463 Compare October 14, 2024 02:55
@lucassaldanha lucassaldanha enabled auto-merge (squash) October 14, 2024 03:02
@lucassaldanha lucassaldanha merged commit b35d70a into Consensys:master Oct 14, 2024
16 of 17 checks passed
@lucassaldanha lucassaldanha deleted the remove-builder-unused-methods branch October 14, 2024 03:43
tbenr pushed a commit to zilm13/teku that referenced this pull request Oct 14, 2024
@lucassaldanha @tbenr
Remove unused methods on ExecutionPayloadBuilder (Consensys#8718)
9a2c8c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucassaldanha @gfukushima @rolfyone