Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SchemaDefinitionCache from rest builder client #8693

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove SchemaDefinitionCache from rest builder client #8693

merged 2 commits into from
Oct 18, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Oct 9, 2024

I think we are using SchemaDefinitionCache in places where it's not needed

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr requested a review from StefanBratanov October 14, 2024 15:27
gfukushima
gfukushima approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tbenr tbenr enabled auto-merge (squash) October 18, 2024 06:49
StefanBratanov
StefanBratanov approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit b22b3d5 into Consensys:master Oct 18, 2024
17 checks passed
@tbenr tbenr deleted the remove-schemadefinitioncache-from-builder branch October 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbenr @StefanBratanov @gfukushima