Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing TODO #8683

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Removing TODO #8683

merged 2 commits into from
Oct 8, 2024

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Oct 8, 2024 •
edited
Loading

PR Description

Previous rebase left two TODOs that are not necessary. And was also skipping consolidation_request tests.

gfukushima
gfukushima approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucassaldanha lucassaldanha enabled auto-merge (squash) October 8, 2024 02:30
@lucassaldanha lucassaldanha merged commit 22421e8 into Consensys:master Oct 8, 2024
16 of 17 checks passed
@lucassaldanha lucassaldanha deleted the cleanup branch October 8, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @gfukushima