Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark local-el retrieved blobs as seen WRT gossip equivocation cache #8675

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Oct 3, 2024

updates the equivocation data used in the gossip rule when we publish the blob_sidecar reconstructed via local el blob lookup.
Moreover it avoids republishing when the recovered blob isn't from current slot
ethereum/consensus-specs#3864

@tbenr tbenr changed the title Mark local-el retrieved blobs as seen Mark local-el retrieved blobs as seen WRT gossip equivocation cache Oct 3, 2024
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a nit

@tbenr tbenr enabled auto-merge (squash) October 4, 2024 12:27
@tbenr tbenr merged commit 234f711 into Consensys:master Oct 4, 2024
16 of 17 checks passed
@tbenr tbenr deleted the mark-local-el-retrieved-blobs-as-seen branch October 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants