Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetAggregateAttestationV2 API #8464

Merged

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jul 23, 2024

PR Description

Add GetAggregateAttestationV2 API

Fixed Issue(s)

fixes #8420

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added GetAggregateAttestationV2 API to handle Electra attestations, deprecating the previous version.

  • Updated CHANGELOG.md to include the new GetAggregateAttestationV2 API.
  • Deprecated GetAggregateAttestation in data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v1_validator_aggregate_attestation.json.
  • Added GetAggregateAttestationV2 endpoint in data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v2_validator_aggregate_attestation.json.
  • Introduced GetAggregatedAttestationResponseV2.json schema for the new API response.
  • Implemented GetAggregateAttestationV2 class in data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/GetAggregateAttestationV2.java.

9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@mehdi-aouadi mehdi-aouadi self-assigned this Jul 23, 2024
@mehdi-aouadi mehdi-aouadi force-pushed the 8420-get-aggregate-attestation branch from f176325 to eb4f50a Compare July 24, 2024 15:23
@mehdi-aouadi mehdi-aouadi force-pushed the 8420-get-aggregate-attestation branch from eb4f50a to 270adb9 Compare July 24, 2024 15:28
@lucassaldanha lucassaldanha merged commit 8c36891 into Consensys:master Jul 24, 2024
16 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8420-get-aggregate-attestation branch July 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the new GetAggregateAttestation V2 API
2 participants