Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases demonstrating external-signer voluntary exit #8463

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

rolfyone
Copy link
Contributor

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

New test cases have been added to VoluntaryExitCommandTest.java to demonstrate the functionality of external signers for voluntary exits.

  • Updated teku/src/integration-test/java/tech/pegasys/teku/cli/subcommand/VoluntaryExitCommandTest.java to include new test methods for external signers.
  • Added mock server configurations to simulate external signer responses.
  • Enhanced existing methods to remove redundant parameters and handle edge cases like signer unavailability and signature validation.
  • Ensured tests cover scenarios such as successful exits, rejected exits, and future epoch handling.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@lucassaldanha lucassaldanha enabled auto-merge (squash) July 24, 2024 03:38
@lucassaldanha lucassaldanha merged commit e55c9cb into Consensys:master Jul 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants