Migrate Teku to Java 21 #8462

StefanBratanov · 2024-07-22T10:26:14Z

PR Description

Changed source/target compatibility to 21
Changed CircleCI openjdk images to 21
Updated Besu libraries since now we support 21 as well

Fixed Issue(s)

fixes #8381

Documentation

I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

I thought about adding a changelog entry, and added one if I deemed necessary.

greptile-apps

PR Summary

Migrated Teku to Java 21, updating build configurations, dependencies, and Docker setups.

Updated .circleci/config.yml to use cimg/openjdk:21.0.2 for all CircleCI jobs.
Modified build.gradle to set source and target compatibility to Java 21.
Deleted docker/jdk17/Dockerfile and added docker/jdk21/Dockerfile for Java 21.
Updated gradle/versions.gradle to use Hyperledger Besu 24.7.0.
Refactored beacon/sync/src/main/java/tech/pegasys/teku/beacon/sync/forward/multipeer/batches/SyncSourceBatch.java and PeerSync.java to use Java 21 features.

_{9 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/RandomSszDataGenerator.java to suppress warnings for PatternMatchingInstanceof, aligning with Java 21's new features.
No significant logical changes were made to the functionality of the RandomSszDataGenerator class.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated build.gradle to set source and target compatibility to Java 21.
Modified CircleCI configuration to use OpenJDK 21 images.
Updated Besu libraries to ensure compatibility with Java 21.
Added docker/jdk21/Dockerfile to create a custom runtime and install Teku on Ubuntu 24.04 with JDK 21.
Adjusted infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/RandomSszDataGenerator.java to suppress PatternMatchingInstanceof warnings.

_{No file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/RandomSszDataGenerator.java to use Java 21's pattern matching for instanceof.
Modified infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/SszDataAssert.java to leverage Java 21's pattern matching for instanceof.
Ensured all tests pass to verify the new syntax does not introduce issues.

_{2 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/RandomSszDataGenerator.java to use Java 21's pattern matching for instanceof.
Modified infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/SszDataAssert.java to leverage Java 21's pattern matching for instanceof.
Ensured all tests pass to verify the new syntax does not introduce issues.

No major changes found since the last review.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated infrastructure/ssz/src/testFixtures/java/tech/pegasys/teku/infrastructure/ssz/SszTestUtils.java to use Java 21 features like toList() and instanceof pattern matching.
Ensured compatibility with Java 21 by changing CircleCI openjdk images to 21.
Updated Besu libraries to support Java 21.

No major changes found since the last review.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated infrastructure/ssz/src/test/java/tech/pegasys/teku/infrastructure/ssz/schema/TreeNodeAssert.java to use Java 21's pattern matching for instanceof.
Changed source/target compatibility to Java 21.
Updated CircleCI openjdk images to version 21.
Upgraded Besu libraries to ensure compatibility with Java 21.

No major changes found since the last review.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated fork-choice-tests/src/integration-test/java/tech/pegasys/teku/forkChoiceTests/ForkChoiceIntegrationTest.java to use Java 21 features like pattern matching and toList().
Changed source/target compatibility to Java 21.
Updated CircleCI openjdk images to version 21.
Upgraded Besu libraries to ensure compatibility with Java 21.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated .circleci/config.yml to use cimg/openjdk:21.0.2 for CI builds.
Modified build.gradle to set source and target compatibility to Java 21.
Deleted docker/jdk17/Dockerfile and added docker/jdk21/Dockerfile for Java 21.
Updated NodeDataProvider and DataProvider to include new parameters and methods for handling recent chain data.
Enhanced NodeDataProviderTest.java with new tests for getAttestationsAndMetaData method.

_{17 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/SszGenericContainerTestExecutor.java to leverage Java 21's enhanced pattern matching.
Updated .circleci/config.yml to use cimg/openjdk:21.0.2 for CI builds.
Modified build.gradle to set source and target compatibility to Java 21.
Deleted docker/jdk17/Dockerfile and added docker/jdk21/Dockerfile for Java 21.
Updated Besu libraries to ensure compatibility with Java 21.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated .circleci/config.yml to use cimg/openjdk:21.0.2 for CI builds.
Modified build.gradle to set source and target compatibility to Java 21.
Deleted docker/jdk17/Dockerfile and added docker/jdk21/Dockerfile for Java 21.
Updated Besu libraries to ensure compatibility with Java 21.
Corrected indentation in eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/SszGenericContainerTestExecutor.java for better readability.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated .circleci/config.yml to support Java 21, ensuring CI pipeline compatibility.
Modified build.gradle to set source and target compatibility to Java 21.
Added docker/jdk21/Dockerfile for Java 21, replacing the old JDK 17 Dockerfile.
Updated Besu libraries to ensure compatibility with Java 21.
Corrected indentation in eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/SszGenericContainerTestExecutor.java for better readability.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

The migration to Java 21 for Teku includes updates to build configurations, dependencies, and Docker setups.

Updated .circleci/config.yml to support Java 21, ensuring CI pipeline compatibility.
Modified build.gradle to set source and target compatibility to Java 21.
Added docker/jdk21/Dockerfile for Java 21, replacing the old JDK 17 Dockerfile.
Updated Besu libraries to ensure compatibility with Java 21.
Corrected indentation in eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/SszGenericContainerTestExecutor.java for better readability.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

tbenr

LGTM

bgravenorst · 2024-07-24T23:53:05Z

Teku docs already mention that Java 21+ is required: https://docs.teku.consensys.io/development/get-started/install/build-from-source#prerequisites

StefanBratanov added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jul 22, 2024

greptile-apps bot reviewed Jul 22, 2024

View reviewed changes

StefanBratanov mentioned this pull request Jul 22, 2024

Update install instructions to Java 21 Consensys/doc.teku#590

Merged

greptile-apps bot reviewed Jul 22, 2024

View reviewed changes

StefanBratanov force-pushed the teku_java21 branch from d48c021 to 65c1ee3 Compare July 22, 2024 12:17

greptile-apps bot reviewed Jul 22, 2024

View reviewed changes

tbenr approved these changes Jul 23, 2024

View reviewed changes

StefanBratanov added 13 commits July 23, 2024 16:09

Migrate Teku to Java 21

5f0e107

try to fix assemble

532699f

Upgrade codeql java version from 17 to 21

4388156

fix one more

ef99627

more stuff

982cf1d

assemble

418a61c

assemble

3e410f3

assemble

f304685

fix stuff

3055315

fix assemble

78f0f56

try stuff

049ab28

fix

918c728

stuff

a091929

StefanBratanov force-pushed the teku_java21 branch from d0b2238 to a091929 Compare July 23, 2024 15:09

StefanBratanov enabled auto-merge (squash) July 23, 2024 15:09

StefanBratanov merged commit 39f5968 into Consensys:master Jul 23, 2024
16 checks passed

StefanBratanov deleted the teku_java21 branch July 23, 2024 16:43

bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jul 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Teku to Java 21 #8462

Migrate Teku to Java 21 #8462

StefanBratanov commented Jul 22, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

tbenr left a comment

bgravenorst commented Jul 24, 2024

Migrate Teku to Java 21 #8462

Migrate Teku to Java 21 #8462

Conversation

StefanBratanov commented Jul 22, 2024 • edited Loading

PR Description

Fixed Issue(s)

Documentation

Changelog

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

tbenr left a comment

Choose a reason for hiding this comment

bgravenorst commented Jul 24, 2024

StefanBratanov commented Jul 22, 2024 •

edited

Loading