-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shut down VC when no keys #8355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
8290-vc-keys
branch
from
June 5, 2024 10:48
efa067c
to
da98868
Compare
mehdi-aouadi
force-pushed
the
8290-vc-keys
branch
from
June 6, 2024 14:43
79f9b95
to
1cb26f8
Compare
so i guess just for context, to test... startup a minimal node, then create validator config (
then run
expect: fail run
expect: starts, keymanager is enabled run
expect: starts, remote signer enabled run
expect: starts all of this was fine. |
rolfyone
reviewed
Jun 11, 2024
teku/src/integration-test/java/tech/pegasys/teku/cli/subcommand/ValidatorClientCommandTest.java
Show resolved
Hide resolved
rolfyone
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Shut down immediately when running a standalone validator (
teku vc
subcommand) without providing any key sources:Fixed Issue(s)
fixes #8290
Documentation
doc-change-required
label to this PR if updates are required.Changelog