Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shut down VC when no keys #8355

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jun 5, 2024

PR Description

Shut down immediately when running a standalone validator (teku vc subcommand) without providing any key sources:

  • No local keys path
  • No external signer
  • Not enabling the key-manager API

Fixed Issue(s)

fixes #8290

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi marked this pull request as draft June 5, 2024 11:29
@mehdi-aouadi mehdi-aouadi marked this pull request as ready for review June 5, 2024 12:00
@rolfyone
Copy link
Contributor

so i guess just for context, to test... startup a minimal node, then create validator config (min-vc.yaml):

network: "auto"
data-path: min-vc
log-destination: "both"

then run

$TEKU vc --config-file min-vc.yaml

expect: fail

run

$TEKU vc --config-file min-vc.yaml --validator-api-enabled --Xvalidator-api-ssl-enabled=false

expect: starts, keymanager is enabled

run

$TEKU vc --config-file min-vc.yaml --validators-external-signer-url http://localhost:19000

expect: starts, remote signer enabled
even without web3signer active

run

$TEKU vc --config-file min-vc.yaml --validator-api-enabled --Xvalidator-api-ssl-enabled=false \
 --validators-external-signer-url http://localhost:19000

expect: starts

all of this was fine.

@mehdi-aouadi mehdi-aouadi requested a review from rolfyone June 11, 2024 07:15
@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) June 11, 2024 14:42
@mehdi-aouadi mehdi-aouadi merged commit 244ec44 into Consensys:master Jun 11, 2024
16 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8290-vc-keys branch October 25, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail when no keys provided to the VC
2 participants