Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Besu dependencies #8288

Merged
merged 17 commits into from
Jul 3, 2024
Merged

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 3, 2024

PR Description

Besu upgraded from 0.9.0 version few months back - hyperledger/besu#6422 so can upgrade our version as well.

Leaving as draft because of following Besu changelog in release https://github.com/hyperledger/besu/releases/tag/24.3.0:

Following the OpenMetrics convention, the updated Prometheus client adds the _total suffix to every metrics of type counter, with the effect that some existing metrics have been renamed to have this suffix. If you are using the official Besu Grafana dashboard (available here), just update it to the latest revision, that accepts the old and the new name of the affected metrics. If you have a custom dashboard or use the metrics in other ways, then you need to manually update it to support the new naming.

Fixed Issue(s)

Fixes #8327

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov changed the title Update io.prometheus:simpleclient Update Besu dependencies May 3, 2024
@StefanBratanov StefanBratanov marked this pull request as draft May 3, 2024 10:32
@gfukushima
Copy link
Contributor

gfukushima commented Jun 4, 2024

I've fixed the tests and am comparing to the current stable version to check which metrics we should adjust in the dashboard, since the new version adds suffix to some types by default. Please don't merge this until further notice.

@gfukushima gfukushima marked this pull request as ready for review June 5, 2024 08:07
@gfukushima gfukushima self-assigned this Jun 6, 2024
@gfukushima gfukushima added the DO NOT MERGE Not ready to merge label Jun 7, 2024
@gfukushima gfukushima removed the DO NOT MERGE Not ready to merge label Jun 24, 2024
@gfukushima gfukushima enabled auto-merge (squash) June 25, 2024 05:35
@gfukushima
Copy link
Contributor

This is now ready for merge.

Copy link
Contributor Author

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just change the CHANGELOG - move the metrics stuff from Upcoming Breaking Changes to Breaking Changes

@gfukushima
Copy link
Contributor

I've cleared the change logs and have added an entry for breaking changes. The announcements were for the previous release.

@gfukushima gfukushima merged commit f4da3e3 into Consensys:master Jul 3, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Besu metrics dependencies
3 participants