-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7002: Add ExecutionLayerWithdrawalRequest for Electra #8197
EIP-7002: Add ExecutionLayerWithdrawalRequest for Electra #8197
Conversation
...java/tech/pegasys/teku/spec/datastructures/operations/ExecutionLayerWithdrawRequestTest.java
Fixed
Show fixed
Hide fixed
...lient/src/main/java/tech/pegasys/teku/ethereum/executionclient/schema/WithdrawRequestV1.java
Outdated
Show resolved
Hide resolved
...src/main/java/tech/pegasys/teku/spec/logic/versions/electra/block/BlockProcessorElectra.java
Outdated
Show resolved
Hide resolved
The OpenApi integration test is failing because we need to create a |
@lucassaldanha I'm pretty sure I will need help writing |
We have a |
I'll take a look |
@rolfyone has implemented this function and it has been merged already. Look for |
@lucassaldanha @rolfyone thanks for your help 😄 this should be ready for review now. |
It looks like the naming was updated to |
Ah I didn't notice that 😢 no problem, will update! Shouldn't be nearly as difficult. |
I just noticed it today hehe. I actually prefer the new name so won't complain about it! The logic seems to be ok so as soon as the names are fixed we can merge it. |
import tech.pegasys.teku.spec.datastructures.execution.versions.electra.ExecutionLayerWithdrawalRequestSchema; | ||
import tech.pegasys.teku.spec.util.DataStructureUtil; | ||
|
||
class ExecutionLayerWithdrawalRequestTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note test
I guess we still need to rename the field in a couple of places? Some of the property tests failed. |
Ah yeah, sorry, missed some of the upper case names. Hopefully that should be it. |
PR Description
This is still a work in progress. This PR will:
ExecutionLayerExit
toExecutionLayerWithdrawalRequest
.amount
field toExecutionLayerWithdrawalRequest
.processExecutionLayerWithdrawalRequests
.Currently, the plan is to merge
ExecutionLayerExit
(EIP-7002) intoExecutionLayerWithdrawalRequest
(EIP-7251) since it's the same concept. This can be seen in this PR by Alex Stokes:Sorry in advance, this PR touches a lot of files. Ideally it would be broken up into multiple PRs, but the changes are relatively simple and breaking it up would be more complicated in my opinion. But if that's desirable, it might be possible.
Documentation
doc-change-required
label to this PR if updates are required.Changelog