Skip to content

Commit

Permalink
Typos and broken links fix (#8408)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucassaldanha authored Jun 26, 2024
1 parent 487b75f commit e0160c7
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# A Github action that using codespell to check spell.
# A Github action that uses codespell to check spell.
# .codespell/.codespellrc is a config file.
# .codespell/wordlist.txt is a list of words that will ignore word checks.
# More details please check the following link:
Expand Down
2 changes: 1 addition & 1 deletion .openapidoc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This directory contains NodeJS project which publishes Teku OpenAPI specificatio
[`gh-pages`](https://github.com/Consensys/teku/tree/gh-pages) branch via CI job after tests are green.
See `publishOpenApiSpec` job in `.circleci/config.yml`.

The actual up to date generated doc is available at https://consensys.github.io/teku/
The actual up-to-date generated doc is available at https://consensys.github.io/teku/

## Procedure

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ You'll find us on [Discord] and that's the fastest way to get an answer.
### Your first code contribution
Start by looking through the 'good first issue' and 'help wanted' issues:
* [Good First Issue][search-label-good-first-issue] - issues which should only require a few lines of code, and a test or two.
* [Help wanted issues][search-label-help-wanted] - issues which are a bit more involved than `good first issue` issues.
* [Help wanted issues][search-label-help-wanted] - issues that are a bit more involved than `good first issue` issues.

### Local Development
The codebase is maintained using the "*contributor workflow*" where everyone without exception contributes patch proposals using "*pull-requests*". This facilitates social contribution, easy testing and peer review.
Expand All @@ -47,7 +47,7 @@ In general a commit serves a single purpose and diffs should be easily comprehen

### Architectural Best Practices

Questions on architectural best practices will be guided by the principles set forth in [Effective Java](http://index-of.es/Java/Effective%20Java.pdf) by Joshua Bloch
Questions on architectural best practices will be guided by the principles set forth in Effective Java by Joshua Bloch

### Automated Test coverage
All code submissions must be accompanied by appropriate automated tests. The goal is to provide confidence in the code’s robustness, while avoiding redundant tests.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ void shouldFetchBlocksLaterThanOneWhichWasBeforeTheCachePeriod() {
blockFetcher.fetch(BigInteger.valueOf(6), BigInteger.valueOf(6));
verifyNoMoreInteractions(eth1Provider);

// When block 5 complete, it should request block 6
// When block 5 is complete, it should request block 6
block5Future.complete(Optional.of(block5));
verify(eth1Provider).getEth1Block(UInt64.valueOf(6));
verifyNoMoreInteractions(eth1Provider);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ void shouldFallbackOnGetGuaranteedEth1Block_byHash()
final SafeFuture<EthBlock.Block> blockByHash =
fallbackAwareEth1Provider.getGuaranteedEth1Block("");

// we expect a delayed action after all nodes has been contacted
// we expect a delayed action after all nodes have been contacted
assertThat(asyncRunner.hasDelayedActions()).isTrue();
verify(node1, atLeastOnce()).getEth1Block("");
verify(node2, atLeastOnce()).getEth1Block("");
Expand Down

0 comments on commit e0160c7

Please sign in to comment.