Trigger primary BN readiness check when failover has issues

Consensys · Apr 12, 2024 · c5c33e5 · c5c33e5
1 parent 8ac4353
commit c5c33e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/...r/remote/src/main/java/tech/pegasys/teku/validator/remote/BeaconNodeReadinessManager.java b/...r/remote/src/main/java/tech/pegasys/teku/validator/remote/BeaconNodeReadinessManager.java
@@ -77,6 +77,10 @@ public Iterator<? extends RemoteValidatorApiChannel> getFailoversInOrderOfReadin
         .iterator();
   }
 
+  public SafeFuture<Void> performPrimaryReadinessCheck() {
+    return performReadinessCheck(primaryBeaconNodeApi, true);
+  }
+
   @Override
   protected SafeFuture<?> doStart() {
     return performReadinessCheckAgainstAllNodes();
@@ -136,10 +140,6 @@ private SafeFuture<Void> performReadinessCheckAgainstAllNodes() {
     return SafeFuture.allOf(primaryReadinessCheck, SafeFuture.allOf(failoverReadinessChecks));
   }
 
-  private SafeFuture<Void> performPrimaryReadinessCheck() {
-    return performReadinessCheck(primaryBeaconNodeApi, true);
-  }
-
   private SafeFuture<Void> performFailoverReadinessCheck(final RemoteValidatorApiChannel failover) {
     return performReadinessCheck(failover, false);
   }

diff --git a/...va/tech/pegasys/teku/validator/remote/eventsource/EventSourceBeaconChainEventAdapter.java b/...va/tech/pegasys/teku/validator/remote/eventsource/EventSourceBeaconChainEventAdapter.java
@@ -180,16 +180,22 @@ private synchronized void switchToFailoverEventStreamIfAvailable() {
   private void findReadyFailoverAndSwitch() {
     failoverBeaconNodeApis.stream()
         .filter(beaconNodeReadinessManager::isReady)
+        .filter(failover -> !currentEventStreamHasSameEndpoint(failover))
         .findFirst()
         .ifPresentOrElse(
             this::switchToFailoverEventStream,
-            validatorLogger::noFailoverBeaconNodesAvailableForEventStreaming);
+            () -> {
+              validatorLogger.noFailoverBeaconNodesAvailableForEventStreaming();
+              // if no failover switching is available, and we are currently connected to a failover
+              // event stream which has issues, trigger the readiness check against the primary BN
+              // immediately in the background
+              if (!currentEventStreamHasSameEndpoint(primaryBeaconNodeApi)) {
+                beaconNodeReadinessManager.performPrimaryReadinessCheck();
+              }
+            });
   }
 
   private void switchToFailoverEventStream(final RemoteValidatorApiChannel beaconNodeApi) {
-    if (currentEventStreamHasSameEndpoint(beaconNodeApi)) {
-      return;
-    }
     eventSource.close();
     eventSource = createEventSource(beaconNodeApi);
     currentBeaconNodeUsedForEventStreaming = beaconNodeApi;