add missing electra attestation processing committee check (#8901)

* add missing electra attestation processing committee check
Consensys · Dec 9, 2024 · a04f3ff · a04f3ff
1 parent d10a47d
commit a04f3ff
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/...erenceTest/java/tech/pegasys/teku/reference/common/operations/OperationsTestExecutor.java b/...erenceTest/java/tech/pegasys/teku/reference/common/operations/OperationsTestExecutor.java
@@ -21,7 +21,6 @@
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.collect.ImmutableMap;
-import java.util.List;
 import java.util.Optional;
 import tech.pegasys.teku.ethtests.finder.TestDefinition;
 import tech.pegasys.teku.infrastructure.ssz.SszData;
@@ -68,9 +67,6 @@ public class OperationsTestExecutor<T extends SszData> implements TestExecutor {
 
   public static final String EXPECTED_STATE_FILE = "post.ssz_snappy";
 
-  // TODO remove https://github.com/Consensys/teku/issues/8892
-  private static final List<String> IGNORED_TEST = List.of("invalid_nonset_bits_for_one_committee");
-
   private enum Operation {
     ATTESTER_SLASHING,
     PROPOSER_SLASHING,
@@ -148,11 +144,6 @@ public OperationsTestExecutor(final String dataFileName, final Operation operati
 
   @Override
   public void runTest(final TestDefinition testDefinition) throws Exception {
-    // TODO remove https://github.com/Consensys/teku/issues/8892
-    if (IGNORED_TEST.contains(testDefinition.getTestName())) {
-      return;
-    }
-
     final BeaconState preState = loadStateFromSsz(testDefinition, "pre.ssz_snappy");
 
     final DefaultOperationProcessor standardProcessor =

diff --git a/.../main/java/tech/pegasys/teku/spec/logic/versions/electra/block/BlockProcessorElectra.java b/.../main/java/tech/pegasys/teku/spec/logic/versions/electra/block/BlockProcessorElectra.java
@@ -23,6 +23,7 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.function.Supplier;
+import java.util.stream.IntStream;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.apache.tuweni.bytes.Bytes32;
@@ -725,16 +726,25 @@ private Optional<OperationInvalidReason> checkCommittees(
       final BeaconState state,
       final UInt64 slot,
       final SszBitlist aggregationBits) {
-    int participantsCount = 0;
+    int committeeOffset = 0;
     for (final UInt64 committeeIndex : committeeIndices) {
       if (committeeIndex.isGreaterThanOrEqualTo(committeeCountPerSlot)) {
         return Optional.of(AttestationInvalidReason.COMMITTEE_INDEX_TOO_HIGH);
       }
       final IntList committee =
           beaconStateAccessorsElectra.getBeaconCommittee(state, slot, committeeIndex);
-      participantsCount += committee.size();
+      final int currentCommitteeOffset = committeeOffset;
+      final boolean committeeHasAtLeastOneAttester =
+          IntStream.range(0, committee.size())
+              .anyMatch(
+                  committeeParticipantIndex ->
+                      aggregationBits.isSet(currentCommitteeOffset + committeeParticipantIndex));
+      if (!committeeHasAtLeastOneAttester) {
+        return Optional.of(AttestationInvalidReason.PARTICIPANTS_COUNT_MISMATCH);
+      }
+      committeeOffset += committee.size();
     }
-    if (participantsCount != aggregationBits.size()) {
+    if (committeeOffset != aggregationBits.size()) {
       return Optional.of(AttestationInvalidReason.PARTICIPANTS_COUNT_MISMATCH);
     }
     return Optional.empty();