Explain TODO comment

Consensys · Apr 26, 2024 · 8b8b79c · 8b8b79c
1 parent d994eeb
commit 8b8b79c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...re/ssz/src/main/java/tech/pegasys/teku/infrastructure/ssz/schema/SszCollectionSchema.java b/...re/ssz/src/main/java/tech/pegasys/teku/infrastructure/ssz/schema/SszCollectionSchema.java
@@ -49,7 +49,9 @@ default SszCollectionT createFromElements(final List<? extends SszElementT> elem
   }
 
   default TreeNode createTreeFromElements(final List<? extends SszElementT> elements) {
-    // TODO: suboptimal
+    // TODO: probably suboptimal method implementation:
+    // This is a generic implementation which works for both Vector and List but it potentially
+    // could do better if construct the tree directly in List/Vector subclasses
     checkArgument(elements.size() <= getMaxLength(), "Too many elements for this collection type");
     SszMutableComposite<SszElementT> writableCopy = getDefault().createWritableCopy();
     int idx = 0;