Skip to content

Commit

Permalink
add missing electra attestation processing committee check
Browse files Browse the repository at this point in the history
  • Loading branch information
mehdi-aouadi committed Dec 9, 2024
1 parent 4ac3018 commit 4d459b2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.collect.ImmutableMap;
import java.util.List;
import java.util.Optional;
import tech.pegasys.teku.ethtests.finder.TestDefinition;
import tech.pegasys.teku.infrastructure.ssz.SszData;
Expand Down Expand Up @@ -68,9 +67,6 @@ public class OperationsTestExecutor<T extends SszData> implements TestExecutor {

public static final String EXPECTED_STATE_FILE = "post.ssz_snappy";

// TODO remove https://github.com/Consensys/teku/issues/8892
private static final List<String> IGNORED_TEST = List.of("invalid_nonset_bits_for_one_committee");

private enum Operation {
ATTESTER_SLASHING,
PROPOSER_SLASHING,
Expand Down Expand Up @@ -148,11 +144,6 @@ public OperationsTestExecutor(final String dataFileName, final Operation operati

@Override
public void runTest(final TestDefinition testDefinition) throws Exception {
// TODO remove https://github.com/Consensys/teku/issues/8892
if (IGNORED_TEST.contains(testDefinition.getTestName())) {
return;
}

final BeaconState preState = loadStateFromSsz(testDefinition, "pre.ssz_snappy");

final DefaultOperationProcessor standardProcessor =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Optional;
import java.util.function.Supplier;
import java.util.stream.IntStream;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.tuweni.bytes.Bytes32;
Expand Down Expand Up @@ -732,6 +733,16 @@ private Optional<OperationInvalidReason> checkCommittees(
}
final IntList committee =
beaconStateAccessorsElectra.getBeaconCommittee(state, slot, committeeIndex);
final int committeeOffset = participantsCount;
long committeeAttesters =
IntStream.range(0, committee.size())
.filter(
committeeParticipantIndex ->
aggregationBits.isSet(committeeOffset + committeeParticipantIndex))
.count();
if (committeeAttesters == 0) {
return Optional.of(AttestationInvalidReason.PARTICIPANTS_COUNT_MISMATCH);
}
participantsCount += committee.size();
}
if (participantsCount != aggregationBits.size()) {
Expand Down

0 comments on commit 4d459b2

Please sign in to comment.