Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hex normalization in getTransactions #467

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

khanti42
Copy link
Collaborator

QA session discovered an issue in the removal of transactions from State due to a misformatting of the transaction hash in State (does not comply with the 66 characters standard of Starknet). This PR solves this.

@khanti42 khanti42 requested a review from a team as a code owner December 17, 2024 11:32
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team December 17, 2024 11:32
@khanti42 khanti42 force-pushed the fix/hex-normalization branch from 3e50a3b to ca137ad Compare December 17, 2024 11:42
@khanti42 khanti42 force-pushed the fix/hex-normalization branch from ca137ad to 076557c Compare December 17, 2024 15:30
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
9.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 7667538 Dec 18, 2024
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/hex-normalization branch December 18, 2024 09:54
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants