feat: refactor RPC starkNet_getTransactions with StarkScan
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient (#453) * feat: add stark scan client * chore: add starkscan config * chore: lint * chore: add interface * chore: support multiple txn * chore: update starkscan * chore: update stark scan client * chore: update contract func name * chore: fix test * chore: update data client * chore: re-structure starkscan type * chore: add test coverage * chore: factory and config * chore: add backward compatibility for transactions type * chore: add comment * chore: lint * chore: resolve review comment * chore: change dataVersion to enum * chore: lint * chore: update test helper and refactor ContractAddressFilter * chore: lint * chore: add test for dataVersion filter * chore: update txn state mgr test * chore: update search condition * chore: update starkscan to handle missing selector_name * chore: apply starkscan for list transaction * chore: update list transactions handle * chore: resolve comment * chore: update function name --------- Co-authored-by: khanti42 <[email protected]>
* feat: add stark scan client * chore: add starkscan config * chore: lint * chore: add interface * chore: support multiple txn * chore: update starkscan * chore: update stark scan client * chore: update contract func name * chore: fix test * chore: update data client * chore: re-structure starkscan type * chore: add test coverage * chore: factory and config * chore: add backward compatibility for transactions type * chore: add comment * chore: lint * chore: resolve review comment * chore: change dataVersion to enum * chore: lint * chore: update test helper and refactor ContractAddressFilter * chore: lint * chore: add test for dataVersion filter * chore: update txn state mgr test * chore: update search condition * chore: update starkscan to handle missing selector_name * chore: apply starkscan for list transaction * chore: update list transactions handle * chore: refactor execute txn * chore: refactor execute txn * chore: update create account and upgrade account * chore: lint * Revert "chore: lint" This reverts commit 12be249. * Revert "chore: update create account and upgrade account" This reverts commit cf64931. * chore: resolve comment * chore: resolve comment * chore: remove space --------- Co-authored-by: khanti42 <[email protected]>
…ntLegacy`, `starkNet_upgradeAccContract` to handle new txn state (#458) * feat: add stark scan client * chore: add starkscan config * chore: lint * chore: add interface * chore: support multiple txn * chore: update starkscan * chore: update stark scan client * chore: update contract func name * chore: fix test * chore: update data client * chore: re-structure starkscan type * chore: add test coverage * chore: factory and config * chore: add backward compatibility for transactions type * chore: add comment * chore: lint * chore: resolve review comment * chore: change dataVersion to enum * chore: lint * chore: update test helper and refactor ContractAddressFilter * chore: lint * chore: add test for dataVersion filter * chore: update txn state mgr test * chore: update search condition * chore: update starkscan to handle missing selector_name * chore: apply starkscan for list transaction * chore: update list transactions handle * chore: refactor execute txn * chore: refactor execute txn * chore: update create account and upgrade account * chore: lint * Revert "chore: lint" This reverts commit 12be249. * Revert "chore: update create account and upgrade account" This reverts commit cf64931. * chore: update rpcs to handle v2 data * chore: update rpcs to handle new txn state data * chore: fix naming --------- Co-authored-by: khanti42 <[email protected]>
* feat: add stark scan client * chore: add starkscan config * chore: lint * chore: add interface * chore: support multiple txn * chore: update starkscan * chore: update stark scan client * chore: update contract func name * chore: fix test * chore: update data client * chore: re-structure starkscan type * chore: add test coverage * chore: factory and config * chore: add backward compatibility for transactions type * chore: add comment * chore: lint * chore: resolve review comment * chore: change dataVersion to enum * chore: lint * chore: update test helper and refactor ContractAddressFilter * chore: lint * chore: add test for dataVersion filter * chore: update txn state mgr test * chore: update search condition * chore: update starkscan to handle missing selector_name * chore: apply starkscan for list transaction * chore: update list transactions handle * chore: resolve comment * chore: update wallet-ui to handle new starkNet_getTransactions * chore: rename type * chore: remove unecessary input param * chore: remove unecessary input param * chore: change explorer link to starkscan * chore: fix comments --------- Co-authored-by: stanleyyuen <[email protected]>
stanleyyconsensys
changed the title
starkNet_getTransactions with StarkScan
stanleyyconsensys
requested review from
Akaryatrh and
jonesho
and removed request for
a team
|
|
stanleyyconsensys
deleted the
feat/refactor-list-transactions-with-starkscan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to refactor RPC
starkNet_getTransactionswith StarkScanBEGIN_COMMIT_OVERRIDE
feat: Refactor RPC
starkNet_getTransactionsand change the provider from Voyager to StarkScan (#453) (#457) (#458) (#459)END_COMMIT_OVERRIDE