chore: fix comments

Consensys · Dec 11, 2024 · a94bb1d · a94bb1d
1 parent 70775c7
commit a94bb1d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 17 deletions.
diff --git a/packages/starknet-snap/src/config.ts b/packages/starknet-snap/src/config.ts
@@ -22,9 +22,7 @@ export type SnapConfig = {
   defaultNetwork: Network;
   availableNetworks: Network[];
   preloadTokens: Erc20Token[];
-  rpcEndpoint: {
-    [key: string]: string;
-  };
+  rpcApiKey: string;
   explorer: {
     [key: string]: string;
   };
@@ -52,14 +50,8 @@ export const Config: SnapConfig = {
     STARKNET_SEPOLIA_TESTNET_NETWORK,
   ],
 
-  rpcEndpoint: {
-    [constants.StarknetChainId.SN_MAIN]:
-      // eslint-disable-next-line no-restricted-globals
-      `https://starknet-mainnet.infura.io/v3/${process.env.DIN_API_KEY ?? ''}`,
-    [constants.StarknetChainId.SN_SEPOLIA]:
-      // eslint-disable-next-line no-restricted-globals
-      `https://starknet-sepolia.infura.io/v3/${process.env.DIN_API_KEY ?? ''}`,
-  },
+  // eslint-disable-next-line no-restricted-globals
+  rpcApiKey: process.env.DIN_API_KEY ?? '',
 
   explorer: {
     [constants.StarknetChainId.SN_MAIN]:

diff --git a/packages/starknet-snap/src/utils/rpc-provider.test.ts b/packages/starknet-snap/src/utils/rpc-provider.test.ts
@@ -1,23 +1,25 @@
 import { constants } from 'starknet';
 
+import { Config } from '../config';
 import { getRPCUrl } from './rpc-provider';
 
 describe('getRPCUrl', () => {
+  Config.rpcApiKey = 'test';
   it('returns Mainnet RPC URL if chain id is Mainnet', () => {
     expect(getRPCUrl(constants.StarknetChainId.SN_MAIN)).toBe(
-      'https://starknet-mainnet.infura.io/v3/',
+      `https://starknet-mainnet.infura.io/v3/${Config.rpcApiKey}`,
     );
   });
 
   it('returns Sepolia RPC URL if chain id is not either Mainnet or Sepolia', () => {
     expect(getRPCUrl('0x534e5f474f45524c49')).toBe(
-      'https://starknet-sepolia.infura.io/v3/',
+      `https://starknet-sepolia.infura.io/v3/${Config.rpcApiKey}`,
     );
   });
 
   it('returns Sepolia RPC URL if chain id is Sepolia', () => {
     expect(getRPCUrl(constants.StarknetChainId.SN_SEPOLIA)).toBe(
-      'https://starknet-sepolia.infura.io/v3/',
+      `https://starknet-sepolia.infura.io/v3/${Config.rpcApiKey}`,
     );
   });
 });
diff --git a/packages/starknet-snap/src/utils/rpc-provider.ts b/packages/starknet-snap/src/utils/rpc-provider.ts
@@ -3,15 +3,16 @@ import { constants } from 'starknet';
 import { Config } from '../config';
 
 /**
+ * Gets the rpc URL for a given Chain ID.
  *
- * @param chainId
+ * @param chainId - The Chain ID.
  */
 export function getRPCUrl(chainId: string) {
   switch (chainId) {
     case constants.StarknetChainId.SN_MAIN:
-      return Config.rpcEndpoint[constants.StarknetChainId.SN_MAIN];
+      return `https://starknet-mainnet.infura.io/v3/${Config.rpcApiKey}`;
     default:
     case constants.StarknetChainId.SN_SEPOLIA:
-      return Config.rpcEndpoint[constants.StarknetChainId.SN_SEPOLIA];
+      return `https://starknet-sepolia.infura.io/v3/${Config.rpcApiKey}`;
   }
 }