Skip to content

Commit

Permalink
fix: add cache key for different env in CICD (#270)
Browse files Browse the repository at this point in the history
* fix: add cache key for different env in CICD

* fix: incorrect pointer for CACHE_KEY

* fix: incorrect pointer for CACHE_KEY
  • Loading branch information
stanleyyconsensys authored Jul 2, 2024
1 parent 61ab4b9 commit 762b536
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ jobs:
AWS_CLOUDFRONT_DISTRIBUTIONS_ID: ${{ steps.prepare_parameters.outputs.AWS_CLOUDFRONT_DISTRIBUTIONS_ID }}
AWS_S3_URL: ${{ steps.prepare_parameters.outputs.AWS_S3_URL }}
GET_STARKNET_PUBLIC_PATH: ${{ steps.prepare_parameters.outputs.GET_STARKNET_PUBLIC_PATH }}
CACHE_KEY: ${{ github.sha }}-${{ steps.prepare_parameters.outputs.ENV }}

install-build:
needs:
Expand Down Expand Up @@ -124,7 +125,7 @@ jobs:
./packages/starknet-snap/dist
./packages/starknet-snap/snap.manifest.json
./node_modules/.yarn-state.yml
key: ${{ github.sha }}
key: ${{ needs.prepare-deployment.outputs.CACHE_KEY }}

publish-npm-dry-run:
runs-on: ubuntu-latest
Expand All @@ -151,7 +152,7 @@ jobs:
./packages/starknet-snap/dist
./packages/starknet-snap/snap.manifest.json
./node_modules/.yarn-state.yml
key: ${{ github.sha }}
key: ${{ needs.prepare-deployment.outputs.CACHE_KEY }}
- name: Dry Run Publish
run: |
npm pack ./packages/starknet-snap --tag "$TAG" --access public
Expand Down Expand Up @@ -183,7 +184,7 @@ jobs:
./packages/starknet-snap/dist
./packages/starknet-snap/snap.manifest.json
./node_modules/.yarn-state.yml
key: ${{ github.sha }}
key: ${{ needs.prepare-deployment.outputs.CACHE_KEY }}
- name: Run Publish
run: |
npm publish ./packages/starknet-snap --tag "$TAG" --access public
Expand Down Expand Up @@ -217,7 +218,7 @@ jobs:
./packages/starknet-snap/dist
./packages/starknet-snap/snap.manifest.json
./node_modules/.yarn-state.yml
key: ${{ github.sha }}
key: ${{ needs.prepare-deployment.outputs.CACHE_KEY }}
- name: Deploy to AWS
run: |
echo "Deployed Dapp to : $AWS_S3_URL"
Expand Down Expand Up @@ -251,7 +252,7 @@ jobs:
./packages/starknet-snap/dist
./packages/starknet-snap/snap.manifest.json
./node_modules/.yarn-state.yml
key: ${{ github.sha }}
key: ${{ needs.prepare-deployment.outputs.CACHE_KEY }}
- name: Deploy to AWS
run: |
echo "Deployed get Starknet to : $AWS_S3_GET_STARKNET_URL"
Expand Down

0 comments on commit 762b536

Please sign in to comment.