-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve constant expression evaluator #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel constants, support more node types and cast operations)
blitz-1306
added
enhancement
New feature or request
breaking change
Changes that would cause a backward compatibility break
labels
Oct 6, 2023
blitz-1306
commented
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 91.81% 91.65% -0.16%
==========================================
Files 267 267
Lines 6546 6592 +46
Branches 1319 1342 +23
==========================================
+ Hits 6010 6042 +32
- Misses 283 288 +5
- Partials 253 262 +9
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cd1m0
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Just nits
…ed bytes, clamp int to type on cast to bytes.
cd1m0
approved these changes
Oct 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Changes that would cause a backward compatibility break
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
This PR resolves #224 and fixes #227.
Changes
isConstant()
,evalConstantExpr()
):MemberAccess
,IndexAccess
VariableDeclaration
);string <-> bytes
,string / bytes -> fixed bytes
,uint <-> fixed bytes
);Notes
isConstant()
andevalConstantExpr()
are now also acceptingVariableDeclaration
as an input node.Value
type now also includesBuffer
(a breaking change).Regards.