Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fullnameOverwrite and annotations for customising Genesis startup hooks #246

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RudyBricks
Copy link

@RudyBricks RudyBricks commented Nov 11, 2024

Hello,

First of all, thank you very much for providing these Kubernetes configurations and Helm charts. They are extremely valuable to us.

I’d like to propose some changes to address three issues that would otherwise prevent deployment when using subcharts:

  1. The Genesis script may execute after the validator node startup hooks complete, which can cause issues if the besu-peers file doesn't already exist. To resolve this, I’ve made it possible for users to pass custom annotations to the Job/ServiceAccount, allowing better control over the execution order.

  2. The Genesis script generates node names that don’t always match the actual node names generated by the besu-node chart. To address this, I added a fullnameOverwrite parameter to allow control over the naming convention.

  3. I included additional match labels for the blockscout service. Previously, the service didn’t match any pods when deployed via subcharts. With these changes, it should now work reliably in both subchart and non-subchart deployments.

Additionally, I added an example demonstrating a Helm-based deployment using Minikube.

Please let me know what you think.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

@joshuafernandes
Copy link
Contributor

Hello @RudyBricks

Thankyou for this submission. Looks good and makes sense.

One request though, could you add the same to the goquorum side of things as well please so we keep them consistent?

Happy to merge once thats in :)

Cheers

Copy link
Contributor

@joshuafernandes joshuafernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @RudyBricks . To keep things consistent between the two could you add these to the goquorum side of things as well please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants