feat: go-corset front end integration #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DavePearce
force-pushed
the
1688-feat-go-corset-front-end-integration
branch
23 times, most recently
from
41593cc to
998091e
Compare
DavePearce
requested review from
OlivierBBB and
FlorianHuc
and removed request for
OlivierBBB
FlorianHuc
approved these changes
Jan 17, 2025
This puts through some changes to use the new `go-corset` front end. 1) This updates the gradle-tests action to use the `go-corset` front-end instead of the original. Provided this works, other actions will need to be updated accordingly. 2) This updates the version of `go-corset` used in `linea-tracer`. This is necessary because only the latest version of `go-corset` is capable of compiling the constraints. 3) This makes relevant changes to ensure go-corset can compile the zkevm.bin file as necessary for the reference tests. 4) This updates the corset version to incorporate a minor fix relating to coalescing of i8 and byte columns.
Its taken a while to figure out how to tweak the reference test build to support different zkevm.bin files.
DavePearce
force-pushed
the
1688-feat-go-corset-front-end-integration
branch
from
5ae61e9 to
4205725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.