-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TX_INIT and TX_FINL redesign #12
Open
OlivierBBB
wants to merge
18
commits into
main
Choose a base branch
from
11-initialization-section-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5f24c78
fix: TX_INIT now finishes on a context row
OlivierBBB a47d281
fix: initialization section
OlivierBBB dfff726
Merge branch 'main' into 11-initialization-section-fix
OlivierBBB 1fc91a2
ras
OlivierBBB 187adc2
fix: TX_INIT reverts with child
OlivierBBB 1722690
ras: restoring the input file
OlivierBBB 1b72a37
ras
OlivierBBB 3589521
feat: intro for TX_INIT phase + ras
OlivierBBB 2cbe525
fix: finalization section + \finalizationDomSubStamps{...}
OlivierBBB 8f1d3b0
fix: restoring hub/_inputs.tex
OlivierBBB 1b54458
fix: finalizationDomSubStamps use TX_END_STAMP by default
OlivierBBB 522706a
ras
OlivierBBB b16a5ab
fix: review changes
OlivierBBB 2de5034
fix: decrementing sub stamp offsets for \finalizationDomSubStamps
OlivierBBB f28e811
ras: uncommented hub inputs
OlivierBBB 20405fa
fix: TX_FINL requires trimming the COINBASE address
OlivierBBB bb4a849
fix: removed the \finalizationDomSubStamps
OlivierBBB 4843ee0
fix: TX_INIT terminates on a CONTEXT-row
OlivierBBB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
\input{tx_finl/_local} | ||
\section{Finalization phase \lispDone{}} \label{hub: finalization phase} | ||
\subsection{Introduction} \label{hub: finalization phase: intro} \input{tx_finl/intro} | ||
\subsection{Peeking flags \lispDone{}} \label{hub: finalization phase: peeking} \input{tx_finl/peeking} | ||
\subsection{The transaction success case \lispDone{}} \label{hub: finalization phase: success} \input{tx_finl/success} | ||
\subsection{The transaction failure case \lispDone{}} \label{hub: finalization phase: failure} \input{tx_finl/failure} | ||
\section{Finalization phase \lispDone{}} \label{hub: finalization phase} | ||
\subsection{Introduction \lispNone{}} \label{hub: finalization phase: intro} \input{tx_finl/intro} | ||
\subsection{Shorthands \lispTodo{}} \label{hub: finalization phase: shorthands} \input{tx_finl/shorthands} | ||
\subsection{Peeking flags \lispTodo{}} \label{hub: finalization phase: peeking} \input{tx_finl/peeking} | ||
\subsection{Common constraints \lispTodo{}} \label{hub: finalization phase: common constraints} \input{tx_finl/rows/_collage} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,31 @@ | ||
\def\locWeiRefund {\col{caller\_refund}} | ||
\def\locWeiReward {\col{coinbase\_reward}} | ||
% no revert | ||
\def\locTxFinlSuccessSenderAccountOffset {\yellowm{0}} | ||
\def\locTxFinlSuccessCoinbaseAccountOffset {\yellowm{1}} | ||
\def\locTxFinlSuccessTransactionRowOffset {\orangem{2}} | ||
\def\locWeiRefund {\col{sender\_gas\_refund}} | ||
\def\locWeiReward {\col{coinbase\_reward}} | ||
\def\locTxFinlRoffLastExecutionRow {\greenm{1}} | ||
\def\locTxFinlRoffAccSender {\yellowm{0}} | ||
\def\locTxFinlRoffAccCoinbase {\yellowm{1}} | ||
\def\locTxFinlRoffTxn {\orangem{2}} | ||
|
||
\def\locTransactionFailure {\col{transaction\_failure}} | ||
\def\locTransactionSuccess {\col{transaction\_success}} | ||
|
||
\def\locTxFinlSenderAddressHi {\col{sender\_addr\_hi}} | ||
\def\locTxFinlSenderAddressLo {\col{sender\_addr\_lo}} | ||
\def\locTxFinlCoinbaseAddressHi {\col{coinbase\_addr\_hi}} | ||
\def\locTxFinlCoinbaseAddressLo {\col{coinbase\_addr\_lo}} | ||
|
||
% | ||
\def\locTxFinlSuccessSenderAccountOffset {\yellowm{0}} | ||
\def\locTxFinlSuccessCoinbaseAccountOffset {\yellowm{1}} | ||
\def\locTxFinlSuccessTransactionRowOffset {\orangem{2}} | ||
\def\nsrTxFinl {\yellowm{3}} | ||
% revert | ||
\def\locTxFinlFailureSenderAccountOffset {\yellowm{0}} | ||
\def\locTxFinlFailureRecipientAccountOffset {\yellowm{1}} | ||
\def\locTxFinlFailureCoinbaseAccountOffset {\yellowm{2}} | ||
\def\locTxFinlFailureTransactionRowOffset {\orangem{3}} | ||
\def\locTxFinlFailureSenderAccountOffset {\yellowm{0}} | ||
\def\locTxFinlFailureRecipientAccountOffset {\yellowm{1}} | ||
\def\locTxFinlFailureCoinbaseAccountOffset {\yellowm{2}} | ||
\def\locTxFinlFailureTransactionRowOffset {\orangem{3}} | ||
% | ||
\def\locFinlSuccessSenderRefund {\col{sender\_refund}} | ||
\def\locFinlSuccessCoinbaseReward {\col{coinbase\_fee}} | ||
\def\locFinlSuccessSenderRefund {\col{sender\_refund}} | ||
\def\locFinlSuccessCoinbaseReward {\col{coinbase\_fee}} | ||
% | ||
\def\locFinlFailureSenderRefund {\col{sender\_refund}} | ||
\def\locFinlFailureCoinbaseReward {\col{coinbase\_fee}} | ||
\def\locFinlFailureSenderRefund {\col{sender\_refund}} | ||
\def\locFinlFailureCoinbaseReward {\col{coinbase\_fee}} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: you defined 1 line before what's col{max}