-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TX_INIT and TX_FINL redesign #12
Open
OlivierBBB
wants to merge
18
commits into
main
Choose a base branch
from
11-initialization-section-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies extracting relevant data from the transaction
11 tasks
\begin{enumerate} | ||
\item for any ``dom''-offset \col{d} used in a constraint to set $\domStamp \equiv \hubLambda \cdot \col{h} + \col{d}$ (where $\col{h} \equiv \hubStamp$) it should hold that $0 \leq \col{d} < \revertEpsilon$ | ||
\item $0 \leq \revertEpsilon < \selfdestructEpsilon < \hubLambda$ | ||
\item $\col{max} < \revertEpsilon < \finalizationEpsilon < \selfdestructEpsilon < \hubLambda$ where \col{max} is the maximum ``$\domStamp$''-offset encountered in constraints (i.e. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: you defined 1 line before what's col{max}
@letypequividelespoubelles zoom review comments addressed 🙂 |
letypequividelespoubelles
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed together :)
This may be the first time the address is exposed
The main point is that everything which happens during the TX_INIT or TX_EXEC phase (excluding SELFDESTRUCT induced account wiping) happens at the fery latest at the final HUB_STAMP of the TX_EXEC phase. During the TX_FINL phase one has HUB_STAMP == HUB_STAMP_TRANSCTION_END So we can do the gas refund payment of the sender + gas reward of the coinbase using \standardDomSubStamps with dom offsets 0 / 1 respectively. All the scheduled account wiping operations will take place at that same time stamp with DOM_STAMP offset epsilon_selfdestruct > 1 and the relevant SUB_STAMP.
That is cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.