-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D pricing metrics #107
Merged
Merged
3D pricing metrics #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
- Introduce block listener in LineaTransactionSelectorPlugin to handle transaction profitability - Integrate transaction selector handler for processing transactions from the latest block - Extract profitability calculation into a separate method for clarity and maintainability Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
…orPlugin - Implement: Node's perception on Profitability levels of TxPool's contents (lo, hi, avg of TransactionProfitabilityCalculator.profitablePriorityFeePerGas(transaction) / transaction.priorityFeePerGas). Signed-off-by: Ade Lucas <[email protected]>
…orPlugin - Implement: Node's perception on Profitability levels of TxPool's contents (lo, hi, avg of TransactionProfitabilityCalculator.profitablePriorityFeePerGas(transaction) / transaction.priorityFeePerGas). Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
…ics work Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
…SelectorTest.java Signed-off-by: Ade Lucas <[email protected]>
Signed-off-by: Ade Lucas <[email protected]>
… enabled Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
changed the title
Sequencer 3D pricing metrics - Node's perception on Profitability levels of TxPool's contents
3D pricing metrics
Nov 4, 2024
fab-10
force-pushed
the
sequencer-3d-pricing-metrics-ade
branch
from
November 4, 2024 18:42
644c543
to
9ac2555
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
sequencer-3d-pricing-metrics-ade
branch
from
November 4, 2024 19:20
9ac2555
to
fcb4001
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
garyschulte
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blockion suggestions. LGTM
sequencer/src/main/java/net/consensys/linea/config/LineaProfitabilityCliOptions.java
Outdated
Show resolved
Hide resolved
.../java/net/consensys/linea/sequencer/txselection/selectors/ProfitableTransactionSelector.java
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <[email protected]>
fab-10
force-pushed
the
sequencer-3d-pricing-metrics-ade
branch
from
November 6, 2024 08:52
db537b5
to
9f2708e
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
Filter94
reviewed
Nov 19, 2024
sequencer/src/main/java/net/consensys/linea/metrics/HistogramMetrics.java
Show resolved
Hide resolved
Filter94
reviewed
Nov 19, 2024
sequencer/src/main/java/net/consensys/linea/metrics/HistogramMetrics.java
Show resolved
Hide resolved
Filter94
reviewed
Nov 19, 2024
...java/net/consensys/linea/sequencer/txpoolvalidation/LineaTransactionPoolValidatorPlugin.java
Show resolved
Hide resolved
Filter94
reviewed
Nov 19, 2024
sequencer/src/main/java/net/consensys/linea/config/LineaProfitabilityCliOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <[email protected]>
Filter94
approved these changes
Nov 19, 2024
# Conflicts: # gradle.properties
Signed-off-by: Fabio Di Fabio <[email protected]>
…-metrics-ade # Conflicts: # gradle.properties # sequencer/src/main/java/net/consensys/linea/AbstractLineaSharedPrivateOptionsPlugin.java # sequencer/src/main/java/net/consensys/linea/extradata/LineaExtraDataPlugin.java # sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/LineaTransactionPoolValidatorPlugin.java # sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorPlugin.java
# Conflicts: # gradle.properties # sequencer/src/main/java/net/consensys/linea/AbstractLineaSharedPrivateOptionsPlugin.java # sequencer/src/main/java/net/consensys/linea/extradata/LineaExtraDataPlugin.java # sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/LineaTransactionPoolValidatorPlugin.java # sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorPlugin.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the following metrics
1 Node's perception on the latest extraData contents (variable cost, fixed cost, eth gas price) as gauges under the PRICING_CONF category
1 Node's perception on Profitability levels of TxPool's contents (lo, hi, avg of transaction.priorityFeePerGas / TransactionProfitabilityCalculator.profitablePriorityFeePerGas(transaction)) as histogram under the TX_POOL_PROFITABILITY categoty
1 Same metrics as above, but in context of last sealed block (this is relevant only for Sequencer) as histogram under the SEQUENCER_PROFITABILITY category
Each metric category can be enabled indipendently, using the standard metrics-category option.
For histograms, it is possible to configure the buckets using the new conf option
plugin-linea-profitability-metrics-buckets
, that by default is set to0.1, 0.3, 0.5, 0.7, 0.9, 1.0, 1.1, 1.2, 1.5, 2.0, 5.0, 10.0
names of the new exported metrics
fixes https://github.com/Consensys/protocol-misc/issues/953