Apply suggestions from code review

Signed-off-by: Fabio Di Fabio <[email protected]>
Consensys · Apr 10, 2024 · e398ff3 · e398ff3
1 parent 1af5505
commit e398ff3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/PLUGINS.md b/PLUGINS.md
@@ -44,12 +44,14 @@ of a transaction.
 
 #### CLI Options
 
-| Option Name                      | Default Value        | Command Line Argument                             |
-|----------------------------------|----------------------|---------------------------------------------------|
-| MAX_BLOCK_CALLDATA_SIZE          | 70000                | `--plugin-linea-max-block-calldata-size`          |
-| MODULE_LIMIT_FILE_PATH           | moduleLimitFile.toml | `--plugin-linea-module-limit-file-path`           |
-| OVER_LINE_COUNT_LIMIT_CACHE_SIZE | 10_000               | `--plugin-linea-over-line-count-limit-cache-size` |
-| MAX_GAS_PER_BLOCK                | 30_000_000L          | `--plugin-linea-max-block-gas`                    |
+| Option Name                         | Default Value        | Command Line Argument                                 |
+|-------------------------------------|----------------------|-------------------------------------------------------|
+| MAX_BLOCK_CALLDATA_SIZE             | 70000                | `--plugin-linea-max-block-calldata-size`              |
+| MODULE_LIMIT_FILE_PATH              | moduleLimitFile.toml | `--plugin-linea-module-limit-file-path`               |
+| OVER_LINE_COUNT_LIMIT_CACHE_SIZE    | 10_000               | `--plugin-linea-over-line-count-limit-cache-size`     |
+| MAX_GAS_PER_BLOCK                   | 30_000_000L          | `--plugin-linea-max-block-gas`                        |
+| TX_POOL_ENABLE_SIMULATION_CHECK_API | true                 | `--plugin-linea-tx-pool-simulation-check-api-enabled` |
+| TX_POOL_ENABLE_SIMULATION_CHECK_P2P | false                | `--plugin-linea-tx-pool-simulation-check-p2p-enabled` |
 
 
 ### Transaction validation - LineaTransactionValidatorPlugin

diff --git a/...n/java/net/consensys/linea/sequencer/txpoolvalidation/validators/SimulationValidator.java b/...n/java/net/consensys/linea/sequencer/txpoolvalidation/validators/SimulationValidator.java
@@ -57,8 +57,11 @@ public SimulationValidator(
   public Optional<String> validateTransaction(
       final Transaction transaction, final boolean isLocal, final boolean hasPriority) {
 
-    if ((isLocal && txPoolValidatorConf.txPoolSimulationCheckApiEnabled())
-        || (!isLocal && txPoolValidatorConf.txPoolSimulationCheckP2pEnabled())) {
+    final boolean isLocalAndApiEnabled =
+        isLocal && txPoolValidatorConf.txPoolSimulationCheckApiEnabled();
+    final boolean isRemoteAndP2pEnabled =
+        !isLocal && txPoolValidatorConf.txPoolSimulationCheckP2pEnabled();
+    if (isRemoteAndP2pEnabled || isLocalAndApiEnabled) {
 
       final ModuleLineCountValidator moduleLineCountValidator =
           new ModuleLineCountValidator(moduleLineLimitsMap);