Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Docker credentials in Github CI #570

Merged
merged 3 commits into from
Jan 20, 2025
Merged

[Fix] Docker credentials in Github CI #570

merged 3 commits into from
Jan 20, 2025

Conversation

kyzooghost
Copy link
Contributor

This PR implements issue(s) #539 #540

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 20, 2025 06:55 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 6c8a282 into main Jan 20, 2025
26 checks passed
@kyzooghost kyzooghost deleted the fix/ci-docker-credentials branch January 20, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesho jonesho jonesho approved these changes

@jpnovais jpnovais jpnovais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyzooghost @jpnovais @jonesho