Logderivative sum: polish the implementation #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBelling
changed the title
AlexandreBelling
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prover/distributed-inclusion-pover-steps #523 +/- ##
==============================================================================
- Coverage 70.17% 70.17% -0.01%
Complexity 1070 1070
==============================================================================
Files 306 306
Lines 12337 12337
Branches 1179 1179
==============================================================================
- Hits 8658 8657 -1
- Misses 3200 3201 +1
Partials 479 479
*This pull request uses carry forward flags. Click here to find out more. |
Soleimani193
merged commit 5f2718c
into
prover/distributed-inclusion-pover-steps
16 of 17 checks passed
Soleimani193
deleted the
prover/distributed-inclusion-prover-steps-alex
branch
AlexandreBelling
added a commit
that referenced
this pull request
Jan 11, 2025
* replacing external coins and passing m columns to the module * added prover steps, test is passing * moved common functions to a new file * adding doc * polish the implementation (#523) * removing the round from zcatalog * better framework for testing * testing with a top-level compatibility --------- Co-authored-by: AlexandreBelling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist