Skip to content

Commit

Permalink
[Feat] GitHub runner upgrades to beefier runners (#579)
Browse files Browse the repository at this point in the history
* beefed up runner for time-limiting steps

* up specs for e2e test runner

* update workflows with metrics in comments

* updated comments for workflows
  • Loading branch information
kyzooghost authored Jan 23, 2025
1 parent 728487b commit aeac0e0
Show file tree
Hide file tree
Showing 12 changed files with 27 additions and 11 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/all-tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs:
build-and-publish:
needs: [ changes, store_image_name_and_tags, all-tools-tag-only ]
if: ${{ always() && (needs.changes.outputs['all-tools'] == 'true' || needs.all-tools-tag-only.result != 'success' || needs.all-tools-tag-only.outputs.image_tagged != 'true') }}
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~0.5 mins saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
env:
COMMIT_TAG: ${{ needs.store_image_name_and_tags.outputs.commit_tag }}
DEVELOP_TAG: ${{ needs.store_image_name_and_tags.outputs.develop_tag }}
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/bridge-ui-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,21 @@ on:
branches:
- main
paths:
- '.github/workflows/bridge-ui-publish.yml'
- 'bridge-ui/**'
- '!bridge-ui/**/*.md'
push:
branches:
- main
paths:
- '.github/workflows/bridge-ui-publish.yml'
- 'bridge-ui/**'
- '!bridge-ui/**/*.md'

jobs:
publish:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~1 min saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
env:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cache-docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
pull-and-cache-images:
needs: [ check-dockerhub-secrets-present, changes ]
if: ${{ always() && needs.check-dockerhub-secrets-present.outputs.secrets_present == 'true' && needs.changes.outputs.cache_images == 'true' }}
runs-on: [self-hosted, ubuntu-20.04, X64, small]
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coordinator-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
# ? Seems to fail more often on xl
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-large
name: Coordinator tests
steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/postman-build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ concurrency:

jobs:
build-and-publish:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~1 min saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Postman build
env:
COMMIT_TAG: ${{ inputs.commit_tag }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/prover-build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ env:

jobs:
build-and-publish:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~1 min saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Prover build
env:
COMMIT_TAG: ${{ inputs.commit_tag }}
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/prover-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ concurrency:

jobs:
staticcheck:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~1.5 mins saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Prover static check
steps:
- name: install Go
Expand Down Expand Up @@ -52,7 +53,8 @@ jobs:
strategy:
matrix:
go-version: [1.23.x]
runs-on: [self-hosted, ubuntu-22.04, X64, large]
# ~1 min saved vs large
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-xl
name: Prover testing
needs:
- staticcheck
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/reuse-run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ jobs:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
outputs:
tests_outcome: ${{ steps.run_e2e_tests.outcome }}
# xl saves ~0 mins
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-large
steps:
- name: Setup upterm session
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/run-smc-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: Smart contracts test
on:
pull_request:
paths:
- '.github/workflows/run-smc-tests.yml'
- 'contracts/**'
- 'testdata/**'
- 'prover/**'
Expand All @@ -15,6 +16,7 @@ on:
branches:
- main
paths:
- '.github/workflows/run-smc-tests.yml'
- 'contracts/**'
- 'testdata/**'
- 'prover/**'
Expand All @@ -29,7 +31,8 @@ env:

jobs:
run-contract-tests:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~2 mins saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Run smart contracts tests
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/staterecovery-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ jobs:
DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-large
# ~2.5 mins saved vs large
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-xl
name: Staterecovery tests
steps:
- name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/traces-api-facade-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ concurrency:

jobs:
run-tests:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~2 mins saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Traces api facade tests
steps:
- name: Checkout
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/transaction-exclusion-api-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ concurrency:

jobs:
run-tests:
runs-on: [self-hosted, ubuntu-20.04, X64, small]
# ~1.5 mins saved vs small
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Transaction exclusion api tests
steps:
- name: Checkout
Expand Down

0 comments on commit aeac0e0

Please sign in to comment.