Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): AttestV2 doesn't support customABI #857

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Adds support for passing a custom ABI to the attestV2 function.
This lets anyone benefit from error decoding on their custom Portal.

Related ticket

Fixes #856

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.59%. Comparing base (8476c04) to head (6052a5b).

Files with missing lines Patch % Lines
sdk/src/dataMapper/PortalDataMapper.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #857   +/-   ##
=======================================
  Coverage   48.59%   48.59%           
=======================================
  Files          18       18           
  Lines         391      391           
  Branches       63       63           
=======================================
  Hits          190      190           
  Misses        198      198           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the fix/attestv2-doesnt-support-customabi branch from 802b438 to 0b83207 Compare December 11, 2024 08:49
@alainncls alainncls force-pushed the fix/attestv2-doesnt-support-customabi branch from 0b83207 to 6052a5b Compare January 6, 2025 13:45
@alainncls alainncls enabled auto-merge (squash) January 6, 2025 13:46
@alainncls alainncls merged commit 9528da1 into dev Jan 6, 2025
9 checks passed
@alainncls alainncls deleted the fix/attestv2-doesnt-support-customabi branch January 6, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AttestV2 doesn't support customABI
3 participants