fix(contracts): Deployment script doesn't work as intended for PortalRegistry #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
satyajeetkolhapure,
orbmis,
arthur-remy and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #833 +/- ##
===========================================
+ Coverage 48.84% 74.12% +25.28%
===========================================
Files 18 51 +33
Lines 389 885 +496
Branches 63 187 +124
===========================================
+ Hits 190 656 +466
- Misses 196 226 +30
Partials 3 3 ☔ View full report in Codecov by Sentry. |
alainncls
force-pushed
the
fix/deployment-script-doesnt-work-as-intended-for-portalregistry
branch
from
a2bdc70 to
ba3f33d
Compare
alainncls
force-pushed
the
fix/deployment-script-doesnt-work-as-intended-for-portalregistry
branch
from
ba3f33d to
dcdcb0c
Compare
satyajeetkolhapure
approved these changes
Nov 28, 2024
satyajeetkolhapure
force-pushed
the
fix/deployment-script-doesnt-work-as-intended-for-portalregistry
branch
from
dcdcb0c to
f7964f0
Compare
satyajeetkolhapure
deleted the
fix/deployment-script-doesnt-work-as-intended-for-portalregistry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the
isTestnetparam from the constructor to theinitializefunctionRelated ticket
Fixes #807
Type of change
Check list