chore(contracts): Refactor duplicated code to manage the Router address #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
satyajeetkolhapure,
orbmis,
arthur-remy and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #820 +/- ##
===========================================
+ Coverage 48.96% 74.37% +25.41%
===========================================
Files 18 51 +33
Lines 388 886 +498
Branches 61 183 +122
===========================================
+ Hits 190 659 +469
- Misses 195 224 +29
Partials 3 3 ☔ View full report in Codecov by Sentry. |
satyajeetkolhapure
approved these changes
Nov 26, 2024
alainncls
force-pushed
the
chore/refactor-duplicated-code-to-manage-the-router-address
branch
from
61bc606 to
78959ba
Compare
alainncls
force-pushed
the
chore/refactor-duplicated-code-to-manage-the-router-address
branch
from
78959ba to
53d34df
Compare
alainncls
deleted the
chore/refactor-duplicated-code-to-manage-the-router-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a
RouterMangercontract to avoid duplicating this piece of code everywhereRelated ticket
Fixes #819
Type of change
Check list