Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts): Fix lint issues on contracts #812

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

  • Updates Solhint
  • Fixes linting issues on the contracts
  • Switches unnecessary memory to calldata

Related ticket

Fixes #811

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls force-pushed the chore/fix-lint-issues-on-contracts branch from 03a5cdd to 34c1bd2 Compare November 22, 2024 17:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (6725ef2) to head (34c1bd2).

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #812       +/-   ##
===========================================
+ Coverage   48.96%   74.88%   +25.91%     
===========================================
  Files          18       49       +31     
  Lines         388      888      +500     
  Branches       61      182      +121     
===========================================
+ Hits          190      665      +475     
- Misses        195      220       +25     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alainncls alainncls merged commit 3087119 into dev Nov 25, 2024
9 checks passed
@alainncls alainncls deleted the chore/fix-lint-issues-on-contracts branch November 25, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Fix lint issues on contracts
4 participants