Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): As a Developer, I want the SDK to be compatible with the new version of the subgraph #695

Conversation

alainncls
Copy link
Collaborator

@alainncls alainncls commented Aug 23, 2024

What does this PR do?

  1. Migrates the SDK from subgraph v1 to subgraph v2
  2. Upgrades the SDK for the explorer

Consequences:

  • Breaking changes with a new Attestation type
  • Way less calls to the subgraph to get Attestations (from up to 301 calls to display 100 Attestations to only 1 call)

Remaining work:

  • Deploy SDK v2 on npm with the 'beta' tag
  • Replace all the subgraph v1 URLs to subgraph v2 URLs in the SDK configs
  • Improve the integration tests at the SDK level
  • Warn the builders of the breaking changes

Related ticket

Fixes #585

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Aug 23, 2024
@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch from e2b2a75 to ffcfac3 Compare August 26, 2024 08:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (e99f776) to head (ffcfac3).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #695      +/-   ##
==========================================
+ Coverage   92.07%   94.54%   +2.47%     
==========================================
  Files          30       30              
  Lines         492      495       +3     
  Branches      112      112              
==========================================
+ Hits          453      468      +15     
+ Misses         39       27      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch 3 times, most recently from 14a0609 to 93c1c79 Compare August 26, 2024 08:14
Copy link
Contributor

github-actions bot commented Aug 26, 2024

@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 08:16 Inactive
@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch from 93c1c79 to 8832981 Compare August 26, 2024 08:35
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 08:37 Inactive
@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch from 8832981 to 5a424ae Compare August 26, 2024 08:55
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 08:56 Inactive
@alainncls alainncls marked this pull request as ready for review August 26, 2024 08:59
@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch 2 times, most recently from 39fb9ae to b4cbc4f Compare August 26, 2024 13:34
@github-actions github-actions bot temporarily deployed to pull request August 26, 2024 13:35 Inactive
@alainncls alainncls force-pushed the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch from b4cbc4f to 1626c87 Compare August 28, 2024 07:32
@github-actions github-actions bot temporarily deployed to pull request August 28, 2024 07:33 Inactive
@alainncls alainncls enabled auto-merge (squash) August 28, 2024 08:58
@alainncls alainncls merged commit f2f425b into dev Aug 28, 2024
10 checks passed
@alainncls alainncls deleted the feat/as-a-developer-i-want-the-sdk-to-be-compatible-with-the-new-version-of-the-subgraph branch August 28, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a Developer, I want the SDK to be compatible with the new version of the subgraph
3 participants