feat(explorer): As an end-user, I want to get more straight-forward information out of the issuer details page #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
force-pushed
the
feat/new-issuer-page
branch
4 times, most recently
from
e500ca9 to
440f7cf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #672 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 30 30
Lines 492 492
Branches 112 112
=======================================
Hits 453 453
Misses 39 39 ☔ View full report in Codecov by Sentry. |
alainncls
force-pushed
the
feat/new-issuer-page
branch
2 times, most recently
from
0421cd9 to
a03f383
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
2 times, most recently
from
d629058 to
f3e7c7f
Compare
alainncls
changed the title
alainncls
force-pushed
the
feat/new-issuer-page
branch
3 times, most recently
from
5cde9e7 to
c81e551
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
c81e551 to
b30b720
Compare
satyajeetkolhapure
requested review from
alainncls,
orbmis,
arthur-remy,
ars9 and
Solniechniy
as code owners
alainncls
requested changes
Aug 22, 2024
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
879df5b to
1d2c15f
Compare
alainncls
approved these changes
Aug 23, 2024
alainncls
force-pushed
the
feat/new-issuer-page
branch
2 times, most recently
from
d1ba146 to
a688f89
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
a688f89 to
7d37022
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
7d37022 to
bfd8f8d
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
bfd8f8d to
09c9cae
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
09c9cae to
0fddb5d
Compare
alainncls
force-pushed
the
feat/new-issuer-page
branch
from
0fddb5d to
64794fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR contains below changes on the Issuer page:
Changes remaining:
The current Attestations page is changed to allow a 'where' clause in the query parameter, although the total counter shown for the pagination is always the total number of attestations. It needs to change to show Attestation counter for where clause.
There is no easy way showing it, unless we add a new field at the subgraph level. The counter is available for Portals but not for the combination of Portal and Schema. It needs to be implemented in a generic and easy way. (Done with basic pagination)
Logos with dark and light theme need to be revisited for the new page. (Done)
The data file has hardcoded Issuer's Portal + Schema combinations. Those needs to be updated with correct data.
Change the cursor for the link to the attestations (on the counter) (Done)
Related ticket
Fixes #679
Type of change
Check list