Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: As an issuer, I can update another issuer's schema context #325

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Oct 25, 2023

…ma registry

What does this PR do?

Related ticket

Fixes #301

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

Codecov Report

Merging #325 (573f171) into dev (f7ad184) will decrease coverage by 0.11%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##              dev     #325      +/-   ##
==========================================
- Coverage   91.55%   91.45%   -0.11%     
==========================================
  Files          13       13              
  Lines         225      234       +9     
  Branches       53       57       +4     
==========================================
+ Hits          206      214       +8     
  Misses         10       10              
- Partials        9       10       +1     
Files Coverage Δ
contracts/src/PortalRegistry.sol 96.00% <100.00%> (+0.16%) ⬆️
contracts/src/SchemaRegistry.sol 92.30% <87.50%> (-2.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@satyajeetkolhapure satyajeetkolhapure changed the title fix: added updateSchemaIssuer and updateMatchingSchemaIssuers in sche… fix: As an issuer, I can update another issuer's schema context Oct 25, 2023
@alainncls
Copy link
Collaborator

#319 is enough

@alainncls alainncls closed this Oct 25, 2023
@satyajeetkolhapure satyajeetkolhapure deleted the fix/as-an-issuer-i-can-update-another-issuers-schema-context branch October 25, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] As an issuer, I can update another issuer's schema context
3 participants